Matrix Implementation & Vector Operations#2
Open
cahiggins wants to merge 14 commits intocheery:masterfrom
cahiggins:master
Open
Matrix Implementation & Vector Operations#2cahiggins wants to merge 14 commits intocheery:masterfrom cahiggins:master
cahiggins wants to merge 14 commits intocheery:masterfrom
cahiggins:master
Conversation
added 14 commits
October 22, 2017 12:57
Can FMatrix_get_element and GMatrix_get_element be combined?
Support vector/integer addtion, subtraction, multiplication, and division. Also added a vector normalize function and corrected an error in the dot product.
The implementation feels a little off, I'm sure there is a better way to do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not ready for merge. There is still a lot to implement, and the current implementation is probably lacking. I am however posting this as a PR so you can follow along in the development and give comments and criticisms.