updated platform versions#1679
Merged
Merged
Conversation
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
The VMware packer plugin now requires explicit `tools_mode` configuration.
This commit adds proper support for tools_mode with the following improvements:
1. **New Variable: `vmware_tools_mode`**
- Defaults to "attach" for best performance (attaches ISO vs uploading)
- Supports "attach", "upload", and "disable" modes
- Attaching is faster than uploading the ISO into the guest
2. **New Variable: `vmware_tools_source_path`**
- Path to VMware Tools ISO for "attach" mode
- Auto-detects default paths based on host OS:
- macOS: /Applications/VMware Fusion.app/Contents/Library/isoimages/
- Linux: /usr/lib/vmware/isoimages/
- Can be overridden by user for custom paths
3. **Conditional Upload Configuration**
- `tools_upload_flavor` and `tools_upload_path` now only set when tools_mode is "upload"
- Avoids conflicts when using "attach" or "disable" modes
**Benefits:**
- Resolves packer validation errors with latest VMware plugin
- Improves build performance by defaulting to "attach" mode
- Maintains backward compatibility for users who need "upload" mode
- Smart defaults based on guest OS and host OS detection
**Usage Examples:**
```hcl
# Default: attach mode with auto-detected path
# (no additional config needed)
# Custom attach path:
vmware_tools_mode = "attach"
vmware_tools_source_path = "/custom/path/to/vmware-tools.iso"
# Upload mode (previous behavior):
vmware_tools_mode = "upload"
# Disable tools:
vmware_tools_mode = "disable"
```
Fixes issues with packer vmware plugin requiring explicit tools_mode configuration.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
…sting Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
…into new-platform-versions
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.