Skip to content

bump chef dep version constraint to all 18 or 19 infra-client #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashiqueps merged 4 commits into from
Mar 4, 2026
Merged

bump chef dep version constraint to all 18 or 19 infra-client #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99403ba
bump chef dep version constraint to all 18 or 19 infra-client
Stromweld Feb 5, 2026
6d6944a
loosen diff-lcs dep
Stromweld Feb 5, 2026
4801826
add comment
Stromweld Feb 5, 2026
e70556c
Fixed the spec failures because of the diff-lcs bump
ashiqueps Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions chef-cli.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ Gem::Specification.new do |gem|
gem.add_dependency "mixlib-shellout", ">= 2.0", "< 4.0"
gem.add_dependency "ffi-yajl", ">= 1.0", "< 3.0"
gem.add_dependency "minitar", "~> 1.0"
gem.add_dependency "chef", "~> 18.0"
gem.add_dependency "solve", "< 5.0", "> 2.0"
gem.add_dependency "chef", ">= 18.0", "< 20.0"
gem.add_dependency "solve", "> 2.0", "< 5.0"
gem.add_dependency "addressable", ">= 2.3.5", "< 2.9"
gem.add_dependency "cookbook-omnifetch", "~> 0.5"
gem.add_dependency "diff-lcs", ">= 1.2.4", "!= 1.4.0", "< 1.6.0" # 1.4 breaks output. Used in lib/chef/util/diff
gem.add_dependency "diff-lcs", "~> 1.6" # Newer verions of chef-client require diff-lcs ~> 1.6
gem.add_dependency "pastel", "~> 0.7" # used for policyfile differ
gem.add_dependency "license-acceptance", ">= 1.0.11", "< 3"
gem.add_dependency "chef-licensing", "~> 1.0"
Expand Down
12 changes: 6 additions & 6 deletions spec/unit/policyfile/differ_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def output
RUN LIST CHANGED
================

@@ -1,5 +1,7 @@
@@ -1,4 +1,6 @@
recipe[java::default]
recipe[jenkins::master]
-recipe[policyfile_demo::whatever]
Expand Down Expand Up @@ -382,7 +382,7 @@ def output
recipe[c::default]
recipe[d::default]
recipe[e::default]
@@ -12,4 +11,8 @@
@@ -12,3 +11,7 @@
recipe[l::default]
recipe[m::default]
recipe[n::default]
Expand Down Expand Up @@ -438,7 +438,7 @@ def output
apt
---

@@ -1,12 +1 @@
@@ -1,11 +0,0 @@
-{
- "version": "2.7.0",
- "identifier": "16c57abbd056543f7d5a15dabbb03261024a9c5e",
Expand Down Expand Up @@ -511,7 +511,7 @@ def output
bluepill
--------

@@ -1,11 +1,22 @@
@@ -0,0 +1,11 @@
+{
+ "version": "2.3.2",
+ "identifier": "9c6990944d9a347dec8bd375e707ba0aecdc17cd",
Expand Down Expand Up @@ -623,7 +623,7 @@ def output
DEFAULT ATTRIBUTES CHANGED
==========================

@@ -1,4 +1,5 @@
@@ -1,3 +1,4 @@
{
- "greeting": "Attributes, f*** yeah"
+ "greeting": "Attributes, f*** yeah",
Expand Down Expand Up @@ -669,7 +669,7 @@ def output
OVERRIDE ATTRIBUTES CHANGED
===========================

@@ -1,4 +1,5 @@
@@ -1,3 +1,4 @@
{
- "attr_only_updating": "use -a"
+ "attr_only_updating": "use -a",
Expand Down
Loading