DX: Reliable imports (PYTHONPATH) + robust CUDA build hints in setup.sh#27
Open
Mars122 wants to merge 3 commits intochenguolin:mainfrom
Open
DX: Reliable imports (PYTHONPATH) + robust CUDA build hints in setup.sh#27Mars122 wants to merge 3 commits intochenguolin:mainfrom
Mars122 wants to merge 3 commits intochenguolin:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: DX: Make runtime imports reliable and harden setup for CUDA extension builds
Summary
This PR improves the out-of-the-box runtime experience by ensuring local module imports work and by making the CUDA extension build path more robust:
import src.*works regardless of environment.--no-build-isolationwhen available. ffmpeg install is guarded.Changes
torch.utils.cmake_prefix_pathwhen available--recursive --depth 1diff-gaussian-rasterization(andsimple-knnif present) with--no-build-isolationMotivation
Some users encounter
ModuleNotFoundError: No module named 'src'depending on how scripts are launched, and CUDA extension builds may fail without explicit Torch/CUDA path hints. This PR makes both paths more reliable without changing core logic.Notes
License