Fix DashWrapper hydration cache eviction guard on latest-dash#32
Draft
chgiesse wants to merge 116 commits intolatest-dashfrom
Draft
Fix DashWrapper hydration cache eviction guard on latest-dash#32chgiesse wants to merge 116 commits intolatest-dashfrom
chgiesse wants to merge 116 commits intolatest-dashfrom
Conversation
quote> added patch log quote>
swapped mostly falsk with Quart also in docs
- added manual test file - NOTE: Had weird latency issues with the debuging async task - patched watch to be async compatable
…is works right out the box
Tests/integration
…erall functionally seems to be served
Update Dash 3.1
…ive path. sse url for endpoint add routes prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
dash/dash-renderer/src/wrapper/DashWrapper.tsxwith a simple LRU eviction, persistentmemoizedKeys,pathKeymemoization, and targeted invalidation on forced renders.dash/dash-renderer/src/reducers/reducer.jsto storeentriesand anindexmapping so lookups for affected subpaths are O(1) instead of scanning the whole map.dash/dash-renderer/src/wrapper/selectors.tsto consume the newlayoutHashesshape and limit checks to relevant indexed paths only.DashWrapperto avoid callingMap.deletewith an undefined key, which fixed the TypeScript compile error surfaced during the test build.Testing
npm run private::lint.renderer, which completed successfully.cd dash/dash-renderer && npm test -- --runInBand, and the webpack/TypeScript build phase completed (TypeScript error resolved); the Karma browser tests could not execute in this environment because no Chrome binary was available (Please, set "CHROME_BIN" env variable).Codex Task