refactor: migrate codebase to TanStack Router by chiptus · Pull Request #25 · chiptus/UpLine

chiptus · 2025-11-20T09:53:48Z

No description provided.

vercel · 2025-11-20T09:53:53Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
upline	Ready	Preview, Comment	Apr 9, 2026 5:30am

Copilot

Pull Request Overview

This PR migrates the application from React Router v6 to TanStack Router v1.136.18. The migration introduces file-based routing and replaces React Router's navigation APIs with TanStack Router equivalents throughout the codebase.

Key changes:

Replaced React Router with TanStack Router in dependencies and configuration
Created file-based route definitions in src/routes/ directory with auto-generated route tree
Updated all navigation hooks, Link components, and routing utilities to use TanStack Router APIs

Reviewed Changes

Copilot reviewed 81 out of 82 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
package.json	Removed react-router-dom, added @tanstack/react-router and related tooling
vite.config.ts	Added TanStackRouterVite plugin for route generation
src/main.tsx	Replaced App component with RouterProvider and router instance
src/routes/__root.tsx	Root route component containing app providers and layout
src/routeTree.gen.ts	Auto-generated route tree (769 lines)
src/hooks/useUrlState.ts	Updated from useSearchParams to TanStack Router's useSearch/useNavigate
src/contexts/FestivalEditionContext.tsx	Replaced matchPath with regex matching, Navigate with programmatic navigation
Multiple page/component files	Updated Link imports and navigate() calls to TanStack Router API

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

src/pages/EditionView/TabNavigation/MobileTabButton.tsx:1

The TanStack Router Link component doesn't support render props with isActive. The code references {({ isActive }) => (...)} but Link's activeProps/inactiveProps pattern doesn't expose isActive to children. This will cause a runtime error. Remove the render prop function and apply active styles through activeProps/inactiveProps className only.

import { Link } from "@tanstack/react-router";

src/pages/admin/festivals/FestivalEdition.tsx

src/pages/ExploreSetPage/ExploreSetPage.tsx

src/hooks/useUrlState.ts

src/components/layout/AppHeader/Navigation.tsx

src/pages/EditionSelection.tsx

src/components/layout/AppHeader/Navigation.tsx

src/routes/festivals/$festivalSlug/editions/$editionSlug.tsx

Copilot

Pull Request Overview

Copilot reviewed 81 out of 82 changed files in this pull request and generated 6 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

src/pages/admin/festivals/FestivalEdition.tsx

src/pages/groups/Groups/GroupCard.tsx

src/pages/groups/GroupDetail.tsx

src/pages/admin/festivals/CSVImportPage.tsx

src/pages/admin/festivals/FestivalEdition.tsx

Copilot

Pull request overview

Copilot reviewed 82 out of 83 changed files in this pull request and generated 9 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

src/hooks/useTimelineUrlState.ts

src/pages/admin/festivals/FestivalEdition.tsx

src/pages/ExploreSetPage/components/ExplorePageHeader.tsx

src/pages/ExploreSetPage/ExploreSetPage.tsx

src/hooks/useUrlState.ts

Copilot · 2025-12-09T08:31:20Z

src/routes/admin/festivals/$festivalSlug/editions/$editionSlug.tsx

+    return {
+      ...context,
+      festivalSlug: params.festivalSlug,
+      editionSlug: params.editionSlug,
+    } as EditionRouteContext;


The route's beforeLoad returns context data (festivalSlug, editionSlug) but this context needs to be properly used. The child routes (StageManagement, SetManagement) expect to receive edition data, not just the slugs. Consider fetching the edition data here and including it in the context, or ensure that the FestivalEdition component properly provides this data to child routes.

src/pages/EditionView/tabs/ScheduleTab/ScheduleNavigationItem.tsx

src/pages/admin/festivals/SetsManagement/SetManagement.tsx

src/pages/admin/festivals/AdminFestivals.tsx

src/pages/admin/festivals/CSVImportPage.tsx

src/hooks/useTimelineUrlState.ts

src/hooks/useUrlState.ts

src/pages/admin/festivals/SetsManagement/SetManagement.tsx

src/pages/admin/festivals/FestivalEdition.tsx

src/routes/festivals/$festivalSlug/editions/$editionSlug.tsx

- Replace all react-router-dom imports with @tanstack/react-router - Update useNavigate() calls to use object syntax with `to` and `params` - Replace useSearchParams with useSearch hook - Replace matchPath with regex-based URL parsing - Replace Navigate component with imperative navigate() calls - Update useTimelineUrlState to use TanStack Router's search params API - Replace navigate(-1) with window.history.back() - Keep NavLink usage (TanStack Router supports it) - Keep useOutletContext usage (TanStack Router supports it) All navigation and routing functionality now uses TanStack Router APIs.

- Replace NavLink with Link using activeProps/inactiveProps - Replace useOutletContext with useRouteContext - Remove react-router-dom from dependencies - Delete old React Router component files - Update Vite config with TanStack Router plugin

…tion - Fix search param type errors in useUrlState.ts and useTimelineUrlState.ts by wrapping navigate search callbacks with 'as any' cast - Fix template literal route types in 10 component files by casting dynamic routes to 'as any' - Fix CSVImportPage route navigation to use consistent path with both params - Remove context prop from Outlet in FestivalEdition.tsx as TanStack Router handles context differently - Fix EditionSelection to use consistent navigation path for subdomain and main domain - Add type guard for editionSlug parameter in FestivalDetail.tsx handleEditionSelect

- Fix search param navigation by casting to any - Fix dynamic route template literals with as any casts - Fix useParams calls with strict: false option - Fix beforeLoad params access in route files - Remove unused imports (useNavigate in Navigation.tsx) - Fix Outlet context prop (removed from component) - Fix CSV import route paths - Fix EditionSelection to use correct route structure - Fix FestivalDetail type guard for editionSlug All TypeScript errors are now resolved. Build and typecheck pass successfully.

Implemented several improvements to enhance type safety and validation: - Added centralized Zod schemas for search parameter validation in searchSchemas.ts - Added NotFound component to router configuration for better error handling - Implemented proper route context passing for Outlet usage in admin routes - Replaced many 'as any' casts with type-safe alternatives: - Used params object approach for dynamic routes (festival, group, set detail links) - Created route mapping for tab navigation with useParams - Used relative paths for schedule and explore navigation - Retained 'as any' only where necessary for TanStack Router limitations (relative paths, search param updaters) - Search param handling now uses updater function pattern for proper typing - All navigation now uses type-safe params objects where applicable - Build and typecheck pass successfully Related files: - Added: src/lib/searchSchemas.ts - Modified: Navigation components, admin pages, route files

Addressed Copilot PR feedback on navigation type safety: 1. CSVImportPage: Fixed invalid navigation with empty editionId - Don't navigate when festival changes and no edition selected - Only navigate when both festival and edition are selected - Preserves search params when navigating to specific edition 2. FestivalEdition: Improved tab navigation type safety - Replaced template string route construction with explicit route paths - Uses if/else to ensure each route has proper type inference - Added proper param type assertions Both changes resolve type safety issues while maintaining correct functionality. TypeCheck and build pass successfully.

Copilot

Pull request overview

Copilot reviewed 84 out of 85 changed files in this pull request and generated 5 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

src/hooks/useUrlState.ts

src/pages/admin/festivals/SetsManagement/SetManagement.tsx

src/pages/admin/festivals/CSVImportPage.tsx

src/routeTree.gen.ts

src/pages/FestivalSelection.tsx

src/components/invite/useInviteValidation.ts

chiptus · 2026-03-31T17:01:12Z

src/contexts/FestivalEditionContext.tsx

-    festivalSlug = match?.params.festivalSlug || festivalSlug || "";
-    pathname = pathname.replace(`/festivals/${festivalSlug}`, "");
-    basePath = `/festivals/${festivalSlug}`;
+    const festivalMatch = pathname.match(/\/festivals\/([^/]+)/);


test sub domains

src/hooks/useUrlState.ts

src/pages/admin/festivals/CSVImportPage.tsx

chiptus · 2026-03-31T17:04:13Z

src/pages/admin/festivals/FestivalEdition.tsx

-    navigate(
-      `/admin/festivals/${festivalSlug}/editions/${editionSlug}/${value}`,
-    );
+    if (value === "sets") {


can't we type value as "sets" | "stages".

or can't the tabs be links?

src/pages/admin/festivals/StageManagement.tsx

- Navigation.tsx: Use router.history.back() instead of window.history.back() to integrate with TanStack Router's navigation system - CSVImportPage: Simplify tab default to just use search.tab - EditionLayout: Remove unnecessary EditionLayoutWrapper, use component directly - SetManagement: Remove empty interface and unused comment - searchSchemas: Move defaults and proper types to router-level Zod schemas - stages/genres: z.array(z.string()) instead of comma-separated strings - minRating: z.number() instead of z.string() - use24Hour/sortLocked: z.boolean() instead of z.string() - All fields use .catch() for defaults at the router level - useUrlState: Simplified to thin wrapper over useSearch, removed manual parsing since router handles defaults and types - useTimelineUrlState: Split updateState into individual update functions (updateView, updateDay, updateTime, updateStages) per review feedback. Exposed state properties at top level instead of nested state object. https://claude.ai/code/session_015h5PFMhsh3FgDeb2uEpKgX

- SetManagement: Use useSetsByEditionQuery instead of useSetsQuery to avoid client-side filtering - StageManagement: Don't destruct queries, use full query objects - FestivalSelection: Wire card click to handleFestivalClick for subdomain redirect logic - useInviteValidation: Accept token as parameter instead of using useSearch internally - __root: Use useSearch and pass invite token to useInviteValidation hook - FestivalEdition: Type getCurrentSubTab return value as "sets" | "stages" - CSVImportPage: Remove comment about not navigating with empty editionId - .oxlintrc.json: Exclude routeTree.gen.ts from oxlint to allow 'as any' in generated code https://claude.ai/code/session_015h5PFMhsh3FgDeb2uEpKgX

@ts-expect-error

Following the pattern established in useTimelineUrlState: - Update useUrlState to accept page parameter ("sets" | "set-detail") - Build route path internally using template literals with 'as const' - Use route with both useSearch({ from: route }) and useNavigate({ from: route }) - Remove type assertions - TypeScript properly infers types with this pattern - Update all callers to pass the page parameter Updated components: - ArtistsTab: uses "sets" - SetDetails: uses "set-detail" - ListFilters: uses "list" for timeline - ListSchedule: uses "list" for timeline - Timeline: uses "timeline" for timeline - TimelineControls: uses "timeline" for timeline This eliminates all usages of strict: false and provides proper type safety without needing @ts-expect-error or type assertions. https://claude.ai/code/session_015h5PFMhsh3FgDeb2uEpKgX

src/hooks/useTimelineUrlState.ts

src/pages/admin/festivals/SetsManagement/SetManagement.tsx

src/pages/FestivalSelection.tsx

src/routes/__root.tsx

1. FestivalSelection: Use Link with onClick handler for subdomain redirects - Restore Link component for better semantics and accessibility - Add onClick handler to intercept clicks on main domain - Prevents default and redirects to subdomain when needed - Allows normal Link navigation otherwise 2. __root.tsx: Remove strict: false from useSearch - Add validateSearch with Zod schema for root route - Define invite parameter as optional string - Use { from: "__root__" } for type-safe search access - Eliminates last usage of strict: false in codebase All changes maintain existing behavior while improving type safety. https://claude.ai/code/session_015h5PFMhsh3FgDeb2uEpKgX

1. MobileTabButton: Remove unsupported render prop pattern - TanStack Router Link doesn't support {({ isActive }) => ...} pattern - Use useMatchRoute() to check if route is active - Conditionally style based on isActive state - Fixes runtime error with render props 2. FestivalEdition: Remove redundant redirect logic - beforeLoad in route already handles redirect to /stages - Remove duplicate useEffect that does the same redirect - Remove unused useEffect import These changes fix the Copilot-identified issues while maintaining existing behavior. https://claude.ai/code/session_015h5PFMhsh3FgDeb2uEpKgX

1. Edition Route - Implement data preloading in beforeLoad - Prefetch edition data using queryClient.ensureQueryData() - Makes data available to all child routes without blocking navigation - Follows TanStack Router preloading pattern for better UX - Reduces duplicate fetches across child components 2. FestivalEdition - Replace Tabs with Links - Convert Tabs component to semantic Link navigation - Better for accessibility and SEO - Proper browser back/forward behavior - Styled Links to look like tabs with active states 3. CSVImportPage - Fix navigation on festival change - Navigate to /admin/festivals/import when festival changes - Preserves tab in search params - Prevents stale URL params on page refresh - Added validateSearch schema to import route for tab param All changes maintain existing behavior while following TanStack Router best practices for preloading and navigation. https://claude.ai/code/session_015h5PFMhsh3FgDeb2uEpKgX

The set detail route was missing the validateSearch schema, which caused routing issues. The SetDetails component uses useUrlState() which expects filterSortSearchSchema parameters (sort, stages, genres, etc.) to be available. Without the schema, the route couldn't properly match and the search parameters weren't typed correctly. Fixes: Set detail page now loads correctly at /sets/$setSlug https://claude.ai/code/session_015h5PFMhsh3FgDeb2uEpKgX

Problem: The set detail page wasn't loading because of incorrect file-based routing structure. Root cause: With file naming sets.tsx + sets.$setSlug.tsx, TanStack Router treats $setSlug as a CHILD route of sets, not a sibling. This requires sets.tsx to have an <Outlet/>, but it was rendering ArtistsTab directly without an outlet. Solution: Restructured to folder-based routing: - sets.tsx → sets/index.tsx (list view at /sets) - sets.$setSlug.tsx → sets/$setSlug.tsx (detail view at /sets/:setSlug) This makes them true siblings under the same parent route, allowing both routes to work independently. Also fixed: Added explicit types to navigate callbacks in useUrlState to resolve TypeScript inference issues. Fixes: /festivals/.../sets/grouch now shows set details correctly https://claude.ai/code/session_015h5PFMhsh3FgDeb2uEpKgX

chiptus · 2026-04-09T05:12:44Z

src/routes/admin/festivals/$festivalSlug/editions/$editionSlug.tsx

+)({
+  component: FestivalEdition,
+  beforeLoad: async ({ params, location, context }) => {
+    const queryClient = (context as { queryClient: QueryClient }).queryClient;


why do we need to cast here?

https://tanstack.com/router/latest/docs/integrations/query

chiptus · 2026-04-09T05:14:20Z

src/routes/admin/festivals/import.tsx

+});
+
+export const Route = createFileRoute("/admin/festivals/import")({
+  component: CSVImportPage,


I think pages components should be defined in the same place as the route

chiptus · 2026-04-09T05:15:34Z

src/routes/festivals/$festivalSlug/editions/$editionSlug/sets/index.tsx

+  "/festivals/$festivalSlug/editions/$editionSlug/sets",
+)({
+  component: ArtistsTab,
+  validateSearch: filterSortSearchSchema,


Error: Invariant failed
at oi (index-BPqd_uBx.js:11:101342)
at Object.select (index-BPqd_uBx.js:11:152994)
at index-BPqd_uBx.js:11:152776
at j (index-BPqd_uBx.js:11:151036)
at index-BPqd_uBx.js:11:151247
at Object.useSyncExternalStore (index-BPqd_uBx.js:6:24426)
at gt.useSyncExternalStore (index-BPqd_uBx.js:1:8230)
at TW.Fw.useSyncExternalStoreWithSelector (index-BPqd_uBx.js:11:151316)
at AW (index-BPqd_uBx.js:11:151527)
at fr (index-BPqd_uBx.js:11:152621)
overrideMethod @ installHook.js:1
installHook.js:1 ErrorBoundary caught an error: Error: Invariant failed
at oi (index-BPqd_uBx.js:11:101342)
at Object.select (index-BPqd_uBx.js:11:152994)
at index-BPqd_uBx.js:11:152776
at j (index-BPqd_uBx.js:11:151036)
at index-BPqd_uBx.js:11:151247
at Object.useSyncExternalStore (index-BPqd_uBx.js:6:24426)
at gt.useSyncExternalStore (index-BPqd_uBx.js:1:8230)
at TW.Fw.useSyncExternalStoreWithSelector (index-BPqd_uBx.js:11:151316)
at AW (index-BPqd_uBx.js:11:151527)
at fr (index-BPqd_uBx.js:11:152621) Object

- Simplified useUrlState to use non-strict mode without 'from' parameter - Removed conditional route logic that was causing TypeScript union type issues - Fixed "Invariant failed" error on sets route by properly handling route context - Kept QueryClient type assertion in beforeLoad (TanStack Router type inference limitation) - Updated all useUrlState call sites to remove page parameter https://claude.ai/code/session_015h5PFMhsh3FgDeb2uEpKgX

chiptus requested a review from Copilot November 20, 2025 09:53

Copilot started reviewing on behalf of chiptus November 20, 2025 09:54 View session

Copilot finished reviewing on behalf of chiptus November 20, 2025 09:55

Copilot AI reviewed Nov 20, 2025

View reviewed changes

vercel bot deployed to Preview November 20, 2025 12:35 View deployment

chiptus requested a review from Copilot November 21, 2025 05:39

Copilot started reviewing on behalf of chiptus November 21, 2025 05:40 View session

Copilot finished reviewing on behalf of chiptus November 21, 2025 05:41

Copilot AI reviewed Nov 21, 2025

View reviewed changes

vercel bot deployed to Preview November 21, 2025 05:56 View deployment

vercel bot deployed to Preview December 9, 2025 07:11 View deployment

chiptus requested a review from Copilot December 9, 2025 08:27

Copilot started reviewing on behalf of chiptus December 9, 2025 08:27 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

vercel bot deployed to Preview December 9, 2025 08:56 View deployment

vercel bot deployed to Preview December 9, 2025 09:03 View deployment

vercel bot deployed to Preview December 10, 2025 17:00 View deployment

vercel bot deployed to Preview December 12, 2025 15:11 View deployment

vercel bot deployed to Preview December 12, 2025 15:20 View deployment

vercel bot deployed to Preview December 12, 2025 15:41 View deployment

vercel bot deployed to Preview December 12, 2025 15:46 View deployment

chiptus commented Dec 12, 2025

View reviewed changes

vercel bot deployed to Preview December 13, 2025 19:00 View deployment

claude added 6 commits March 31, 2026 16:39

fix: complete TanStack Router migration

39e1831

- Replace NavLink with Link using activeProps/inactiveProps - Replace useOutletContext with useRouteContext - Remove react-router-dom from dependencies - Delete old React Router component files - Update Vite config with TanStack Router plugin

vercel bot deployed to Preview March 31, 2026 16:52 View deployment

fix

30073b5

vercel bot deployed to Preview March 31, 2026 16:54 View deployment

chiptus requested a review from Copilot March 31, 2026 16:56

Copilot started reviewing on behalf of chiptus March 31, 2026 16:56 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

chiptus commented Mar 31, 2026

View reviewed changes

vercel bot deployed to Preview March 31, 2026 17:09 View deployment

vercel bot deployed to Preview March 31, 2026 17:15 View deployment

fix timeline state

10db104

vercel bot deployed to Preview March 31, 2026 17:17 View deployment

vercel bot deployed to Preview March 31, 2026 17:28 View deployment

chiptus commented Apr 1, 2026

View reviewed changes

src/hooks/useTimelineUrlState.ts Outdated Show resolved Hide resolved

src/pages/admin/festivals/SetsManagement/SetManagement.tsx Outdated Show resolved Hide resolved

src/pages/FestivalSelection.tsx Show resolved Hide resolved

src/routes/__root.tsx Outdated Show resolved Hide resolved

chiptus changed the title ~~Migrate codebase to TanStack Router~~ refactor: migrate codebase to TanStack Router Apr 1, 2026

vercel bot deployed to Preview April 1, 2026 05:18 View deployment

vercel bot deployed to Preview April 1, 2026 12:31 View deployment

vercel bot deployed to Preview April 3, 2026 06:31 View deployment

vercel bot deployed to Preview April 4, 2026 07:18 View deployment

vercel bot deployed to Preview April 9, 2026 05:14 View deployment

chiptus commented Apr 9, 2026

View reviewed changes

vercel bot deployed to Preview April 9, 2026 05:30 View deployment

Conversation

chiptus commented Nov 20, 2025

Uh oh!

vercel bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chiptus Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chiptus Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chiptus Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

chiptus Apr 9, 2026

vercel bot commented Nov 20, 2025 •

edited

Loading