docs: update CLAUDE.md phase tracker (PRs #86-104)#105
Conversation
- Phase 3.5 (COA trust-path): NEW, marked COMPLETED - Phase 4: marked COMPLETED (all imports shipped) - Phase 6: marked COMPLETED (allocations, export, email) - Phase 2/5: updated with completed items - Route listing: 20 → 22 files (allocations, email) - Wrangler config: .toml → .jsonc reference - Test count: 35 → 246+ Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
chittyfinance | 2cd9ce0 | Apr 24 2026, 10:49 AM |
1 similar comment
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
chittyfinance | 2cd9ce0 | Apr 24 2026, 10:49 AM |
|
@coderabbitai review Please evaluate:
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation updates the API surface reference to include 22 Hono routes with newly added Changes
Possibly related PRs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review — PR #105: docs: update CLAUDE.md phase tracker (PRs #86-104)Type: Docs-only | Risk: Low | Additions: 51 | Deletions: 29 OverviewThis PR updates the Issues Found🔴 Phase 6 Heading InconsistencyThe heading reads A phase marked
🟡 Duplicate Pending Items Across PhasesTwo pending items now appear in both Phase 2 and Phase 5:
Listing the same work-item in two phases creates ambiguity about where it will actually be tracked and delivered. Pick one phase per item (Phase 5 seems like the more natural home given the ecosystem integration framing) and remove the duplicate from Phase 2. 🟡 COA Account Count Changed Without CalloutThe existing CLAUDE.md (and the in-context system prompt) says "60 REI accounts seeded"; this PR changes it to "80 REI accounts" (Phase 3.5). If the seed script was genuinely updated, this is correct — but verify that 🟢 Minor: Phase 1.5 Loses Test Milestone ContextRemoving What's Done Well
SummarySolid housekeeping PR. Three things to fix before merging:
Everything else is accurate and well-attributed. |
There was a problem hiding this comment.
Pull request overview
Updates CLAUDE.md’s project phase tracker and repository structure notes to reflect recently shipped features and configuration changes.
Changes:
- Marks multiple roadmap phases (3.5, 4, 6) as completed and updates Phase 2/5 completed items.
- Updates the documented route/module listings (including allocations + email) and revises several feature descriptions.
- Updates deploy config reference from
system-wrangler.tomltosystem-wrangler.jsoncand updates stated test count.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| │ ├── index.ts # Legacy Express entry (standalone dev) | ||
| │ ├── routes.ts # Legacy Express routes (reference only) | ||
| │ ├── routes/ # Hono route modules (20 files) | ||
| │ ├── routes/ # Hono route modules (22 files) |
There was a problem hiding this comment.
The route module count looks incorrect. server/routes currently has 32 .ts route modules (accounts.ts … workflows.ts), so “(22 files)” will be misleading. Consider either updating the number to match the directory or removing the specific count if it changes frequently.
| │ ├── routes/ # Hono route modules (22 files) | |
| │ ├── routes/ # Hono route modules |
|
|
||
| ### Phase 1.5: Hono Route Migration (COMPLETED) | ||
| - ✅ All 17 route modules migrated from Express to Hono | ||
| - ✅ All route modules migrated from Express to Hono (22 route files) |
There was a problem hiding this comment.
This claim of “22 route files” doesn’t match the current repository state: server/routes contains 32 route modules. Either update the number or reword to avoid hard-coding a count that will drift over time.
| - ✅ All route modules migrated from Express to Hono (22 route files) | |
| - ✅ All route modules migrated from Express to Hono |
| │ │ └── webhooks.ts # Stripe/Mercury webhooks | ||
| │ │ ├── email.ts # /api/email (Cloudflare Email Service) | ||
| │ │ ├── import.ts # /api/import (TurboTenant, Mercury, HD Pro, Amazon CSV + Wave sync) | ||
| │ │ └── webhooks.ts # Stripe/Mercury/Wave webhooks (per-tenant HMAC) |
There was a problem hiding this comment.
webhooks.ts does include Stripe, Mercury, and Wave endpoints, but only Mercury uses per-tenant HMAC (via tenantId in URL + KV secret). The Wave webhook path is authenticated via CHITTY_AUTH_SERVICE_TOKEN (Bearer token), and Stripe uses Stripe’s signature header. Please adjust this description so it doesn’t imply per-tenant HMAC applies to all three providers.
| │ │ └── webhooks.ts # Stripe/Mercury/Wave webhooks (per-tenant HMAC) | |
| │ │ └── webhooks.ts # Stripe/Mercury/Wave webhooks (Stripe signature, Mercury per-tenant HMAC, Wave Bearer token) |
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation