Repository navigation
Persist session ACL in snapshots; restore on session_load (MN-REQ-06.16) - #215
Merged
Merged
Conversation
…e digest (MN-REQ-06.16 review)
…ed bind and rollback tests (MN-REQ-06.16)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist the session ACL in snapshots and restore it on session_load (MN-REQ-06.16, MN-VER-06-S14). SysML first.
Format:
@SNAPformat version 2 with a mandatory#@ACL: {json}line.@ACL: absent|off.bad_snapshot.Load: session_load restores the enabled flag, the per-caller grants and the bind, for both file load and
--keep-id.Writes:
hmac.compare_digest. Legacy raw leases are hashed on load.<file>.v1.bakis taken beside it. This covers the session, expire, checkpoint and upgrade writers. An existing backup is never overwritten, and there is no v1 dual-write.Rollback / compatibility (by design):
bad_snapshot, orupgrade_snapshot_formatfor a v2 manifest)..v1.bakbackups over the snapshots. That loses every write made after the upgrade.Tests: full suite 586 passed, 1 skipped. Covered:
--keep-idreloadNo version bump or release here (0.19.24 separately).