Support for regex pattern when specifying asset name#161
Open
LLouice wants to merge 2 commits intochshersh:mainfrom
Open
Support for regex pattern when specifying asset name#161LLouice wants to merge 2 commits intochshersh:mainfrom
LLouice wants to merge 2 commits intochshersh:mainfrom
Conversation
chshersh
requested changes
Feb 9, 2023
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
Hmm, initially, I would be against adding regex support to tool-sync but seeing how easy it was to implement it, I think I actually changed my mind!
Thanks for the implementation! I have one minor questions. And also, could you update CHANGELOG and docs README by saying that tool-sync now supports regular expressions? Thanks!
Everything else looks great 👍🏻
src/model/release.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug, PartialEq, Eq)] | ||
| //#[derive(Debug, PartialEq, Eq)] |
Owner
There was a problem hiding this comment.
Let's remove this comment if those two instances are not needed 🧹
chshersh
added
enhancement
Author
|
I'm glad you like it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for regex pattern when specifying asset name
This feature does not break the previous substring rule
Additional tasks