Skip to content

Add entity position fields to allow user to position the entity - #1371

Merged
NotStirred merged 3 commits into
chunky-dev:masterfrom
NotStirred:feature/entity_position_fields
Jul 26, 2022
Merged

NotStirred merged 3 commits into
chunky-dev:masterfrom
NotStirred:feature/entity_position_fields

Conversation

@NotStirred

Copy link
Copy Markdown
Member

Closes #1325

I thought it fit better next to scale and head scale, as it's the position of the entity overall, not the position of any part

image

@Peregrine05

Copy link
Copy Markdown
Member

So far, so good, except that when the selected entity is a lectern, the location controls apply only to the lectern, while all other controls apply to the book on the lectern.
I don't know if this is related, but when a lecten does not have a book, then the lectern does not get an entry in the Entities list.

@NotStirred

Copy link
Copy Markdown
Member Author

I see the issue, lecterns are annoying

@Peregrine05

Copy link
Copy Markdown
Member

The entity location controls now apply to not only the lectern, but also the book on top. Lecterns without books are still not listed in the entities list, however.
image

@NotStirred

Copy link
Copy Markdown
Member Author

we should probably discuss what the behaviour should be
a lectern itself isn't poseable, it just has a position, and so shouldn't really be in the entity list. (like campfires, and other similar "entities")

Should we just have the book and remove the lectern?

@Peregrine05

Copy link
Copy Markdown
Member

Further discussion about the previous comment took place on Discord.

@NotStirred
NotStirred force-pushed the feature/entity_position_fields branch from d50ac3f to 0fc8689 Compare July 20, 2022 15:24
@NotStirred

Copy link
Copy Markdown
Member Author

Removed lectern changes, will push another PR fixing it

@NotStirred

Copy link
Copy Markdown
Member Author

other PR is #1376

@Peregrine05 Peregrine05 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From testing, everything is working as expected, except for the lectern bug, which will be fixed separately.

@NotStirred
NotStirred merged commit 82c1c1a into chunky-dev:master Jul 26, 2022
@NotStirred
NotStirred deleted the feature/entity_position_fields branch July 26, 2022 00:48
NotStirred added a commit to NotStirred/chunky that referenced this pull request Apr 3, 2023
…ky-dev#1371)

* Add entity position fields to allow user to position the entity
* Fix potential NPE if lectern has no book, and returns null pose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fields to set the position of entities

4 participants