Calculate samples per second from time per pass instead of total render time. - #1911
Merged
Merged
Conversation
leMaik
commented
Aug 30, 2026
leMaik
commented
Aug 30, 2026
leMaik
commented
Aug 30, 2026
Fix ns to ms conversion. Co-authored-by: Maik Marschner <m.marschner@wertarbyte.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The samples per second used to be just be the total number of samples divided by the total render time. This means that changes while rendering are not shown and the value is a big average.
#1497 tried to solve this by implementing a moving average. This PR re-calculates the SPS from the time per pass (divided by the samples per pass) after every rendering pass instead. Since we already calculate the elapsed time, this has almost no overhead.
I changed the time resolution to nanoseconds to avoid precision errors.
Closes #697
Supersedes #1497 (which inspired this)