Repository navigation
ci(release): cache Rust builds per platform - #333
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release builds take about 30 minutes. Every run also rebuilt every Rust dependency from scratch on all five platforms, because
release.ymlhad no cache.The package matrix now uses the repo's
rust-cacheaction, keyed per platform. The action gains akeyinput, so matrix jobs that share a runner OS and architecture get separate caches. Its V8 eviction fallback now cleans the profile it caches: before,cargo clean -p v8only cleaneddev, so it never applied to release caches.Results
cargo build --releaseminutes, measured on this PR:Windows (about 21–29 min) and Intel macOS (about 24 min) still bound the total time. With
lto = "fat", the final link generates code for every dependency again, so cached dependencies save the least on the slowest machines.Tried and dropped
crates/chunk-js/build.rsbuilds the V8 startup snapshot on the build machine, so an arm64 build machine produces a snapshot the x64 binary can't load.The remaining big lever is thinner LTO or more codegen units. That trades runtime performance and nightly/release parity, so it's left for a separate decision.
🤖 Generated with Claude Code