Repository navigation
Conversation
aanm
force-pushed
the
pr/aanm/quay-oidc-robot-variables
branch
from
September 25, 2026 13:29
82b8a5a to
391e8d6
Compare
This commit adds support for OIDC, replacing long-lived tokens. Quay.io has been configured accordingly. The robot account name is read from the QUAY_ROBOT_RELEASE variable, defined on the GitHub environment the job pins rather than at repository or organisation level, so the value a job receives is the one belonging to its environment. The environment name also forms the OIDC subject that the robot is configured to trust, so renaming the environment breaks the login. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/aanm/quay-oidc-robot-variables
branch
from
September 25, 2026 14:47
391e8d6 to
bcc6797
Compare
aanm
marked this pull request as ready for review
September 28, 2026 14:13
joestringer
reviewed
Sep 30, 2026
| permissions: | ||
| contents: read | ||
| # Required by the Quay OIDC token exchange. | ||
| id-token: write |
Member
There was a problem hiding this comment.
As far as I understand today, for pull_request triggers, the secrets are not made available to that PR (for external contributions), so the bare make command in the steps is not considered sensitive.
Does this hold true with this new method with id-token? Or would even pull_request triggered PRs gain an OIDC token and have the capability to escalate that to push access with arbitrary write?
Member
Author
There was a problem hiding this comment.
I think we would have huge problems if that was the case. That's the reason why pull_request_target exists.
We can test it after merging but I'm 100% confident this won't work unless we use pull_request_target
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for OIDC, replacing long-lived tokens. Quay.io
has been configured accordingly.
The robot account name is read from the QUAY_ROBOT_RELEASE variable,
defined on the GitHub environment the job pins rather than at repository
or organisation level, so the value a job receives is the one belonging
to its environment. The environment name also forms the OIDC subject
that the robot is configured to trust, so renaming the environment
breaks the login.