Fix NOT_LTE locale messages reusing NOT_GTE's wording - #286
Merged
Conversation
The lte checker's NOT_LTE error message was copy-pasted from NOT_GTE in every one of the 23 shipped locales, so a failing lte:n check rendered as "cannot be less than n" instead of "cannot be greater than n" -- describing the opposite failure. Each locale's NOT_LTE now borrows that locale's existing NOT_MAX_LEN phrasing. Fixes #284 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CgPf2eG8h9xHh7kHFJ4eCs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 86
Lines 1807 1807
=========================================
Hits 1807 1807 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOT_LTEwas a copy-paste ofNOT_GTEin every one of the 23 shipped locale files, so a failinglte:ncheck rendered as "cannot be less than n" (the opposite of what happened) instead of "cannot be greater than n"NOT_LTEmessage now borrows that same locale's existingNOT_MAX_LENphrasing (which already correctly distinguishes greater-than from less-than)lte_test.go's message assertion to matchFixes #284
Test plan
go test -cover ./...at root — 100% coverage maintainedgo test ./locales/...— locale placeholder/coverage consistency test passestask lint(gosec) — 0 issues🤖 Generated with Claude Code
https://claude.ai/code/session_01CgPf2eG8h9xHh7kHFJ4eCs