Restore length check for required on empty array/map/slice - #287
Merged
Conversation
reflectRequired was purely IsZero()-based, but reflect.Value.IsZero()
on a slice only reports true for a nil slice -- a non-nil, zero-length
slice/map (e.g. an explicit []string{} or emails: [] in YAML) passed
required/@required silently. v1 had a dedicated length check for
Array/Map/Slice kinds; restore that behavior so an empty collection is
rejected the same way a nil one is.
Fixes #285
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CgPf2eG8h9xHh7kHFJ4eCs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 86
Lines 1807 1812 +5
=========================================
+ Hits 1807 1812 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reflectRequiredin v2 was purelyIsZero()-based; per the stdlib's own documented semantics,IsZero()on a slice only reportstruefor a nil slice, so a non-nil, zero-length slice/map (e.g. an explicit[]string{}oremails: []in YAML) silently passedrequired/@required-- a regression from v1, which had a dedicated length check forArray/Map/Slicekindsrequiredon a list/map-shaped field means "must have at least one item," matching v1's behaviorFixes #285
Test plan
go test -cover ./...— 100% coverage maintainedtask lint(gosec) — 0 issuesRequired([]string{})now returnsErrRequired;Required([]string{"x"})does not🤖 Generated with Claude Code
https://claude.ai/code/session_01CgPf2eG8h9xHh7kHFJ4eCs