Skip to content

fix(deps): bump jsonwebtoken to 10.4.0 - #439

Merged
tobyhede merged 2 commits into
mainfrom
fix/cip-3809-jsonwebtoken-patch
Aug 18, 2026
Merged

fix(deps): bump jsonwebtoken to 10.4.0#439
tobyhede merged 2 commits into
mainfrom
fix/cip-3809-jsonwebtoken-patch

Conversation

@tobyhede

Copy link
Copy Markdown
Contributor

Bumps jsonwebtoken to 10.4.0, pulled in transitively via stack-auth 0.42.2 (now depends on jsonwebtoken ^10.3.0 instead of the previous ^9.3.1 pin). No direct usage of jsonwebtoken in this repo — clean transitive bump, workspace builds successfully.

Signed-off-by: Toby Hede <toby@cipherstash.com>
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ae0e6c6-a494-4214-862f-993093c610a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@freshtonic freshtonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

Verified the lock-only bump does what the description says:

  • jsonwebtoken 9.3.1 → 10.4.0, arriving via stack-auth 0.42.2, which declares jsonwebtoken = "10.3.0" with default-features = false, features = ["aws_lc_rs", "use_pem"]. That swaps the crypto backend from ring to aws-lc-rs, which is the real substance of this diff — worth naming explicitly, since the PR body reads as a routine version-number bump.
  • No Cargo.toml change is needed here: nothing in this workspace pins the 0.42.x crates exactly, so the lock moves on its own. Confirmed no direct jsonwebtoken usage.
  • The backend swap adds no new build-toolchain burden. aws-lc-rs/aws-lc-sys are already in the lock on main (via rustls), so nothing new has to compile and no CMake/C requirement is introduced by this change.

One incidental change worth noting, not a blocker: winapi-util 0.1.11's windows-sys resolves 0.61.2 → 0.48.0. That's within its declared range (>=0.48.0, <=0.61.*, cfg(windows)-gated only), and it collapses a duplicate windows-sys copy rather than adding one — harmless, just unrelated to the stated change.

Full CI green, including the PG17 shards and the e2e property suite.

Comment thread Cargo.lock Outdated
Comment on lines +4885 to +4888
"windows-sys 0.61.2",
"windows-sys 0.48.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fairly substantive drop. Any idea why that's changed so much?

@coderdan coderdan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but there's one dependency that downgraded by quite a lot. Maybe worth checking before merging.

The jsonwebtoken 10.4.0 bump re-resolved winapi-util's windows-sys
edge from 0.61.2 down to 0.48.0. winapi-util declares a permissive
range (>=0.48.0, <=0.61.*), so both satisfy it and cargo is free to
pick either; pin the lockfile back to 0.61.2.

Inert in practice - the edge is cfg(windows)-gated and CI is Ubuntu
only - but there is no reason to build against three-generation-older
bindings.

Signed-off-by: Toby Hede <toby@cipherstash.com>
@tobyhede
tobyhede added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 2759a17 Aug 18, 2026
20 checks passed
@tobyhede
tobyhede deleted the fix/cip-3809-jsonwebtoken-patch branch August 18, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants