fix(deps): bump jsonwebtoken to 10.4.0 - #439
Conversation
Signed-off-by: Toby Hede <toby@cipherstash.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
freshtonic
left a comment
There was a problem hiding this comment.
Approving.
Verified the lock-only bump does what the description says:
jsonwebtoken9.3.1 → 10.4.0, arriving viastack-auth0.42.2, which declaresjsonwebtoken = "10.3.0"withdefault-features = false, features = ["aws_lc_rs", "use_pem"]. That swaps the crypto backend fromringtoaws-lc-rs, which is the real substance of this diff — worth naming explicitly, since the PR body reads as a routine version-number bump.- No
Cargo.tomlchange is needed here: nothing in this workspace pins the 0.42.x crates exactly, so the lock moves on its own. Confirmed no directjsonwebtokenusage. - The backend swap adds no new build-toolchain burden.
aws-lc-rs/aws-lc-sysare already in the lock onmain(viarustls), so nothing new has to compile and no CMake/C requirement is introduced by this change.
One incidental change worth noting, not a blocker: winapi-util 0.1.11's windows-sys resolves 0.61.2 → 0.48.0. That's within its declared range (>=0.48.0, <=0.61.*, cfg(windows)-gated only), and it collapses a duplicate windows-sys copy rather than adding one — harmless, just unrelated to the stated change.
Full CI green, including the PG17 shards and the e2e property suite.
| "windows-sys 0.61.2", | ||
| "windows-sys 0.48.0", |
There was a problem hiding this comment.
That's a fairly substantive drop. Any idea why that's changed so much?
coderdan
left a comment
There was a problem hiding this comment.
Looks fine, but there's one dependency that downgraded by quite a lot. Maybe worth checking before merging.
The jsonwebtoken 10.4.0 bump re-resolved winapi-util's windows-sys edge from 0.61.2 down to 0.48.0. winapi-util declares a permissive range (>=0.48.0, <=0.61.*), so both satisfy it and cargo is free to pick either; pin the lockfile back to 0.61.2. Inert in practice - the edge is cfg(windows)-gated and CI is Ubuntu only - but there is no reason to build against three-generation-older bindings. Signed-off-by: Toby Hede <toby@cipherstash.com>
Bumps
jsonwebtokento 10.4.0, pulled in transitively viastack-auth0.42.2 (now depends onjsonwebtoken ^10.3.0instead of the previous^9.3.1pin). No direct usage of jsonwebtoken in this repo — clean transitive bump, workspace builds successfully.