Repository navigation
fix(eql): drop ignored query_json cast and correct eql-bindings wire docs - #1548
Draft
cipherstash-agent wants to merge 2 commits into
Draft
cipherstash-agent wants to merge 2 commits into
cipherstash-agent wants to merge 2 commits into
Conversation
…docs PostgreSQL ignores casts whose source type is a domain, so the json_search -> query_json cast never ran to_ste_vec_query. Remove it and document the function as the only conversion. Fix the v3 module docs: op backs _ord/_ord_ope, ob only _ord_ore. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Jmn7qx6btMrkTQ6rQRjDz
🦋 Changeset detectedLatest commit: 19b8ea1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Jmn7qx6btMrkTQ6rQRjDz
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by CipherStash · project thread
Summary
Fixes CIP-5157 (E4, E7). Removes a
CREATE CASTPostgreSQL always ignored, and corrects stale wire-format docs in eql-bindings.Changes
src/v3/json/types.sql: dropCREATE CAST (public.eql_v3_json_search AS eql_v3.query_json). PostgreSQL ignores casts from a domain (warning on every install), sodoc::eql_v3.query_jsonnever calledto_ste_vec_queryand failed thequery_jsonCHECK. A note explains this in place of the cast.tests/sqlx/snapshots/eql_v3_public_surface.txt: remove the cast line. It was listed only because the catalog row exists, though it never took effect.docs/reference/json-support.md: state thateql_v3.to_ste_vec_query(col)is the only document-to-needle conversion.eql-bindings/src/v3/mod.rs:opbacks_ord/_ord_ope,obonly_ord_ore;text_ord/text_searchcarryhm+op. Matcheseql-domainsand the generated structs.@cipherstash/eql.Verification
eql-domains/src/lib.rsand the generatedTextOrd/TextSearchdocs (hmop).skills/needed changes.Related
CIP-5157. The committed SQL bundle under
packages/eql/packages/eql/sqlis regenerated by the release version hook, so it still contains the cast until the next EQL release.Review notes
Removing the cast is behaviour-neutral at runtime, since it was ignored. Only the surface snapshot and install warning change.
Generated by Claude Code