Skip to content

fix: prevent denylisted denylisters from modifying the list #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Omeraydognn wants to merge 2 commits into
base: main
Choose a base branch
from
+34 −0
Open

fix: prevent denylisted denylisters from modifying the list #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ae1de4
fix: prevent denylisted denylisters from modifying the list
Omeraydognn Aug 15, 2026
ca4577f
test: add regression test for denylisted denylister mutation
Omeraydognn Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions contracts/src/Denylist.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ contract Denylist is Initializable, Ownable2StepUpgradeable {
error CannotDenylistOwner();
/// @notice Thrown when caller is not a denylister
error CallerIsNotDenylister();
/// @notice Thrown when caller is denylisted
error CallerIsDenylisted();
/// @notice Thrown when address is zero
error ZeroAddress();

Expand Down Expand Up @@ -56,6 +58,7 @@ contract Denylist is Initializable, Ownable2StepUpgradeable {
modifier onlyDenylister() {
DenylistStorage storage $ = _getDenylistStorage();
if (!$.denylisters[msg.sender]) revert CallerIsNotDenylister();
if ($.denylisted[msg.sender]) revert CallerIsDenylisted();
_;
}

Expand Down
31 changes: 31 additions & 0 deletions contracts/test/Denylist.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,37 @@ contract DenylistTest is Test {
assertTrue(denylist.isDenylisted(alice));
}

function test_Fixed_DenylistedDenylisterCannotMutate() public {
// owner grants denylister to two accounts (compromised, rescuer)
address compromised = address(100);
address rescuer = address(101);

vm.startPrank(owner);
denylist.addDenylister(compromised);
denylist.addDenylister(rescuer);
vm.stopPrank();

// rescuer denylists compromised
address[] memory accountsToDenylist = new address[](1);
accountsToDenylist[0] = compromised;
vm.prank(rescuer);
denylist.denylist(accountsToDenylist);

// compromised tries to un-denylist themselves
address[] memory accountsToUnDenylist = new address[](1);
accountsToUnDenylist[0] = compromised;
vm.prank(compromised);
vm.expectRevert(Denylist.CallerIsDenylisted.selector);
denylist.unDenylist(accountsToUnDenylist);

// compromised also cannot denylist anyone else
address[] memory otherAccounts = new address[](1);
otherAccounts[0] = alice;
vm.prank(compromised);
vm.expectRevert(Denylist.CallerIsDenylisted.selector);
denylist.denylist(otherAccounts);
}

// ============ Add / Remove denylisters (onlyOwner) ============

function test_AddDenylister_OnlyOwner_Success() public {
Expand Down