Only check the label, not the label/pl, for duplicate imports#987
Draft
dpk wants to merge 1 commit intocisco:mainfrom
Draft
Only check the label, not the label/pl, for duplicate imports#987dpk wants to merge 1 commit intocisco:mainfrom
dpk wants to merge 1 commit intocisco:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #929.
I am not yet certain that this patch is complete. At the very least, this demonstrates that the behaviour of importing identifier properties appears to work as expected:
Details
However, I am not sure if
labelcan contain alabel/plas well as theentry-label. Moreover, the Right Thing is probably to still signal a duplicate if an imported identifier has a conflicting property definition, but this patch won’t do that. (Then again, this matches the behaviour that it also won’t stop you defining the same property multiple times in a body.)It may also be that there is a better place to fix this.
There should likely also be a test for this; the above example could serve as a basis.
I would appreciate feedback from those familiar with the innards of
syntax.ss.