Skip to content

Revisions to allow compiling under Windows-mingw64#428

Open
robe2 wants to merge 1 commit intocitusdata:mainfrom
robe2:mingw64-windows
Open

Revisions to allow compiling under Windows-mingw64#428
robe2 wants to merge 1 commit intocitusdata:mainfrom
robe2:mingw64-windows

Conversation

@robe2
Copy link
Copy Markdown

@robe2 robe2 commented Apr 18, 2026

This is to support pg_cron working on windows.

Note I compiled this using msys2-mingw64 but I'm using it under PostgreSQL Windows EDB installs. Seems to work fine. I tested with PG 16 and PG18 but made sure it compiled for PG13-PG18.

I had to make additional adjustments for PG < 15 cause I guess they improved windows headers in PG for 16 and above.

I did use Google AI assistant for some guidance.

The (int 32) casting in the UpdateJobRunDetail was needed, because otherwise I was getting an incompatible cast from int32 to pid_t * {aka long long int *}. I assumed that was better than changing the definition of

 UpdateJobRunDetail(int64 runId, int32 *job_pid, char *status, char *return_message, TimestampTz *start_time,
									TimestampTz *end_time);

To

 UpdateJobRunDetail(int64 runId, pid_t *job_pid, char *status, char *return_message, TimestampTz *start_time,
									TimestampTz *end_time);

But both variants worked.

@robe2
Copy link
Copy Markdown
Author

robe2 commented Apr 18, 2026

@microsoft-github-policy-service agree company="Paragon Corporation"

@robe2 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Paragon Corporation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant