Revisions to allow compiling under Windows-mingw64#428
Open
robe2 wants to merge 1 commit intocitusdata:mainfrom
Open
Revisions to allow compiling under Windows-mingw64#428robe2 wants to merge 1 commit intocitusdata:mainfrom
robe2 wants to merge 1 commit intocitusdata:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree company="Paragon Corporation"
@microsoft-github-policy-service agree company="Paragon Corporation" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support pg_cron working on windows.
Note I compiled this using msys2-mingw64 but I'm using it under PostgreSQL Windows EDB installs. Seems to work fine. I tested with PG 16 and PG18 but made sure it compiled for PG13-PG18.
I had to make additional adjustments for PG < 15 cause I guess they improved windows headers in PG for 16 and above.
I did use Google AI assistant for some guidance.
The (int 32) casting in the UpdateJobRunDetail was needed, because otherwise I was getting an incompatible cast from int32 to pid_t * {aka long long int *}. I assumed that was better than changing the definition of
To
But both variants worked.