This repository was archived by the owner on Feb 17, 2023. It is now read-only.
Improve regex for finding names of archives#49
Open
computerquip-streamlabs wants to merge 1 commit intocjntaylor:devfrom
Open
Improve regex for finding names of archives#49computerquip-streamlabs wants to merge 1 commit intocjntaylor:devfrom
computerquip-streamlabs wants to merge 1 commit intocjntaylor:devfrom
Conversation
computerquip-streamlabs
force-pushed
the
better-regex
branch
from
7dc1bd0 to
0cfdc3c
Compare
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the regex a bit while allowing extended semver such as
v0.0.0-beta.1.It's a bit less flexible but I didn't find anything it didn't work with aside from extremely early node stuff before any stable release.
That said, I can't seem to find where the NW.js checksum file is. Their version of gyp doesn't seem to download one which is a bit concerning though I could just be missing it.