This repository was archived by the owner on Feb 17, 2023. It is now read-only.
Added support for electron beta versions#54
Open
WolverinDEV wants to merge 1 commit intocjntaylor:devfrom
Open
Added support for electron beta versions#54WolverinDEV wants to merge 1 commit intocjntaylor:devfrom
WolverinDEV wants to merge 1 commit intocjntaylor:devfrom
Conversation
|
The problem with this is beta is part of the version and its variable. For instance, there's nightly builds of electron that use "nightly" where this PR won't work anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current file regex does not support electron beta builds.
This pr should fix this :)
An example: