Skip to content
This repository was archived by the owner on Feb 17, 2023. It is now read-only.

Added support for electron beta versions#54

Open
WolverinDEV wants to merge 1 commit intocjntaylor:devfrom
WolverinDEV:dev
Open

Added support for electron beta versions#54
WolverinDEV wants to merge 1 commit intocjntaylor:devfrom
WolverinDEV:dev

Conversation

@WolverinDEV
Copy link

@WolverinDEV WolverinDEV commented Nov 9, 2018

The current file regex does not support electron beta builds.
This pr should fix this :)

An example:

find_package(NodeJS)

set(NODEJS_URL "https://atom.io/download/atom-shell")
set(NODEJS_VERSION "v4.0.0-beta.7")
nodejs_init()

@WolverinDEV WolverinDEV changed the title Added support for node beta versions Added support for electron beta versions Nov 9, 2018
@computerquip-streamlabs
Copy link

The problem with this is beta is part of the version and its variable. For instance, there's nightly builds of electron that use "nightly" where this PR won't work anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants