Skip to content

fix(chat): hide agent-facing text in task cards - #233

Merged
juacker merged 5 commits into
mainfrom
fix/task-cards-hide-result
Oct 16, 2026
Merged

juacker merged 5 commits into
mainfrom
fix/task-cards-hide-result

Conversation

@juacker

@juacker juacker commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Task cards in the chat showed agent-facing markdown raw (result previews, instructions, message bodies, a blocked worker's BLOCKED: reply). That text is for the agent; the user can read it via Open task. This hides it instead of rendering it.

  • Task result card: keeps agent, title, cycle, status pill, Open task. Removed preview, Show full result/less, expand state.
  • Delegated / status-check card: keeps agent, title, status, click-to-open. Removed instructions and result summary. The red error line now shows only for failed tasks that weren't blocked (system errors such as a missing run record); a blocked task's reply — which the backend also copies into error — no longer leaks, and the pill reads Blocked instead of Failed.
  • Click to open: result and stop cards open the task on a click anywhere (like delegated/status cards); the result card's "Open task" button is gone.
  • Message card: unchanged from main (markdown preview + Show full message) — messages between agents stay readable like a chat.

Production +122/−138, tests +82/−83. Lint, tsc, vitest (Agents + AssistantChat, 218) and ipc_surface pass locally. Independent review r1 needs_fixes (blocked-reply leak) → fixed in 99a4a2c. Not checked visually in the running app.

Task result, hand-off/poll, and message cards showed markdown written for
agents (result summaries, instructions, message bodies) as raw text. Drop
it: the cards keep the agent, title, status and Open task; the task's log
has the full text. A task's own run error stays on hand-off/poll cards.
A blocked task stores the worker's BLOCKED: reply as its error too, so the
poll card showed it in red under a Failed pill. Carry failureReason, show the
error line only for a failed task that is not blocked, and label a blocked
failure Blocked.
@juacker
juacker marked this pull request as ready for review October 16, 2026 20:56
@juacker
juacker merged commit c041934 into main Oct 16, 2026
2 checks passed
@juacker
juacker deleted the fix/task-cards-hide-result branch October 16, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant