Refactor ParentClient to extend BaseClient and add login#49
Open
s2owl wants to merge 1 commit intoclasschartsapi:mainfrom
Open
Refactor ParentClient to extend BaseClient and add login#49s2owl wants to merge 1 commit intoclasschartsapi:mainfrom
s2owl wants to merge 1 commit intoclasschartsapi:mainfrom
Conversation
Refactor ParentClient class to extend BaseClient and implement login functionality with TES SSO handshake. Remove old tests and add new methods for pupil management and password change.
Author
|
fix(parentClient): handle TES SSO handshake to prevent redirect loop (#48) |
IsaacHatton
suggested changes
May 6, 2026
Contributor
IsaacHatton
left a comment
IsaacHatton
left a comment
There was a problem hiding this comment.
Hi @s2owl it looks like you have only edited the test file, not the parentClient.ts file itself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor ParentClient class to extend BaseClient and implement login functionality with TES SSO handshake. Remove old tests and add new methods for pupil management and password change.