fix(mosaic): preserve OTP preparation state during navigation by austincalvelage · Pull Request #10564 · clerk/javascript

austincalvelage · 2026-10-31T04:55:23Z

Description

Opening the method picker while a verification code was being sent discarded the eventual send result. Returning with Back could hide a delivery failure and leave Resend disabled, or allow verification to submit before preparation finished.

Keep preparation active while navigating between code entry, the method picker, and help. Back preserves the send result and cooldown without sending another code. Failed delivery shows the error and allows immediate resend. Cancellation and selecting a different method discard stale results.

Clear test authentication cookies when browser test iframes unload, preventing stale cookies from causing HTTP 431 failures in subsequent test files.

Fixes CORE-4063. Reusing preparation after selecting another method is separate follow-up work in CORE-4065.

Checklist

pnpm test runs as expected for the affected flow. Feature and browser suites pass; live Chrome checks confirmed preserved failures, cooldowns, and no extra preparation requests during navigation.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2026-10-31T04:55:27Z

🦋 Changeset detected

Latest commit: a691aef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/mosaic	Patch
@clerk/swingset	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-10-31T04:55:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
clerk-js-sandbox	Ready	Preview	Nov 2, 2026 10:54pm UTC
swingset	Ready	Preview	Nov 2, 2026 10:54pm UTC

coderabbitai · 2026-10-31T04:55:31Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Source mode: Auto
Repository: clerk/javascript
Branch: austin/core-4063-preserve-otp-preparation-failure-after-opening-the-method
File: .coderabbit.yaml
Commit: a691aef
Layers: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 1a2fea13-43bf-4cb0-a10f-2cb07a9d8839

Commits

Reviewing files that changed from the base of the PR and between d8b57fb and a691aef.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: clerk/javascript
Branch: austin/core-4063-preserve-otp-preparation-failure-after-opening-the-method
File: .coderabbit.yaml
Commit: 8a828bd
Layers: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: a3511bc8-9e57-4dc0-9c40-ff0202c63b83

Commits

Reviewing files that changed from the base of the PR and between bf080c2 and 8a828bd.

Files selected for processing: 2

packages/mosaic/src/features/reverification/__tests__/reverification.feature.test.tsx
packages/mosaic/src/features/reverification/reverification.controller.ts

Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

clerk/clerk_go (manual)
clerk/dashboard (manual)
clerk/accounts (manual)
clerk/backoffice (manual)
clerk/clerk (manual)
clerk/clerk-docs (manual)
clerk/cloudflare-workers (manual)
clerk/clerk-android (auto-detected)
clerk/cli (auto-detected)
clerk/clerk-ios (auto-detected)

Limit details: You’ve used all 5 included reviews currently available. Your 52 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The reverification controller now uses an overlay stack for method-picker and help navigation. It gates submission and resend while overlays are open, and clears overlays after preparation completes or the challenge becomes inactive. New tests cover navigation during preparation, held submissions, and late results. Browser test setup clears cookies on pagehide, with a test for cookie state around that event.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: ephem

Merge Risk: Minimal · previous review 8a828

No material merge-readiness risk was established for code-preparation navigation or browser-test cookie cleanup.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely identifies the main change: preserving OTP preparation state during navigation.
Description check		The description directly explains the verification-flow fix and the related browser test cookie cleanup.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 4 functions across 4 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

pkg-pr-new · 2026-10-31T04:58:07Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10564

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10564

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10564

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10564

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10564

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10564

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10564

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10564

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10564

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10564

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10564

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10564

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10564

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10564

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10564

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10564

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10564

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10564

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10564

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10564

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10564

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10564

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10564

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10564

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10564

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10564

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10564

commit: a691aef

…stack Replace the methodPicker and help states with an overlay stack in context, so navigating away from a factor never leaves preparing or verifying. Move the preparation navigation tests into the feature suite.

vercel Bot deployed to Preview – clerk-js-sandbox October 31, 2026 04:55

View deployment

github-actions Bot added the mosaic label Oct 31, 2026

vercel Bot deployed to Preview – swingset October 31, 2026 04:57

View deployment

vercel Bot deployed to Preview – clerk-js-sandbox October 31, 2026 05:48

View deployment

vercel Bot deployed to Preview – swingset October 31, 2026 05:51

View deployment

github-actions Bot added the actions label Oct 31, 2026

vercel Bot deployed to Preview – clerk-js-sandbox October 31, 2026 06:29

View deployment

vercel Bot deployed to Preview – swingset October 31, 2026 06:31

View deployment

vercel Bot deployed to Preview – clerk-js-sandbox October 31, 2026 06:56

View deployment

vercel Bot deployed to Preview – swingset October 31, 2026 06:59

View deployment

austincalvelage changed the title ~~fix(mosaic): preserve OTP preparation across method navigation~~ fix(mosaic): preserve OTP preparation state during navigation Oct 31, 2026

austincalvelage marked this pull request as ready for review October 31, 2026 16:32

vercel Bot deployed to Preview – clerk-js-sandbox October 31, 2026 16:32

View deployment

vercel Bot deployed to Preview – swingset October 31, 2026 16:34

View deployment

austincalvelage mentioned this pull request Oct 31, 2026

fix(mosaic): reuse valid OTP preparation across method navigation #10566

Open

3 of 9 tasks

austincalvelage added this pull request to stack #10567 October 31, 2026 17:56

austincalvelage force-pushed the austin/core-4063-preserve-otp-preparation-failure-after-opening-the-method branch from 470b146 to 2c24b60 Compare November 2, 2026 18:11

vercel Bot deployed to Preview – clerk-js-sandbox November 2, 2026 18:11

View deployment

vercel Bot deployed to Preview – swingset November 2, 2026 18:13

View deployment

coderabbitai Bot mentioned this pull request Nov 2, 2026

test(mosaic): avoid session cookie buildup in feature tests #10586

Merged

4 of 9 tasks

austincalvelage force-pushed the austin/core-4063-preserve-otp-preparation-failure-after-opening-the-method branch from 2c24b60 to bf080c2 Compare November 2, 2026 20:04

vercel Bot deployed to Preview – clerk-js-sandbox November 2, 2026 20:05

View deployment

vercel Bot deployed to Preview – swingset November 2, 2026 20:07

View deployment

austincalvelage requested a review from alexcarpenter November 2, 2026 20:15

coderabbitai Bot mentioned this pull request Nov 2, 2026

fix(mosaic): preserve field and global reverification errors #10558

Merged

3 of 9 tasks

austincalvelage force-pushed the austin/core-4063-preserve-otp-preparation-failure-after-opening-the-method branch from bf080c2 to 8a828bd Compare November 2, 2026 20:35

vercel Bot deployed to Preview – clerk-js-sandbox November 2, 2026 20:36

View deployment

alexcarpenter approved these changes Nov 2, 2026

View reviewed changes

vercel Bot deployed to Preview – swingset November 2, 2026 20:39

View deployment

austincalvelage force-pushed the austin/core-4063-preserve-otp-preparation-failure-after-opening-the-method branch from 8a828bd to d8b57fb Compare November 2, 2026 21:36

vercel Bot deployed to Preview – clerk-js-sandbox November 2, 2026 21:36

View deployment

vercel Bot deployed to Preview – swingset November 2, 2026 21:38

View deployment

austincalvelage added 5 commits November 2, 2026 15:51

fix(mosaic): preserve OTP preparation across method navigation

d468e1a

chore(ci): diagnose Mosaic browser initialization timeout

3c235e0

test(mosaic): clear authentication cookies when test iframes unload

8c6328c

docs(mosaic): add OTP navigation release note

a691aef

austincalvelage force-pushed the austin/core-4063-preserve-otp-preparation-failure-after-opening-the-method branch from d8b57fb to a691aef Compare November 2, 2026 22:51

vercel Bot deployed to Preview – clerk-js-sandbox November 2, 2026 22:52

View deployment

vercel Bot deployed to Preview – swingset November 2, 2026 22:54

View deployment

austincalvelage merged commit bae8b90 into main Nov 2, 2026
56 checks passed

austincalvelage deleted the austin/core-4063-preserve-otp-preparation-failure-after-opening-the-method branch November 2, 2026 23:59

clerk-cookie mentioned this pull request Nov 3, 2026

ci(repo): Version packages #10571

Open

Navigation Menu

Repository navigation

fix(mosaic): preserve OTP preparation state during navigation - #10564

fix(mosaic): preserve OTP preparation state during navigation#10564
austincalvelage merged 5 commits into
mainfrom
austin/core-4063-preserve-otp-preparation-failure-after-opening-the-method

austincalvelage commented Oct 31, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 31, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 31, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 31, 2026 •

edited

Loading

Review skipped

Uh oh!

pkg-pr-new Bot commented Oct 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

austincalvelage commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-bot Bot commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

pkg-pr-new Bot commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

austincalvelage commented Oct 31, 2026 •

edited

Loading

changeset-bot Bot commented Oct 31, 2026 •

edited

Loading

vercel Bot commented Oct 31, 2026 •

edited

Loading

coderabbitai Bot commented Oct 31, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 31, 2026 •

edited

Loading