chore(ui,shared,types): Remove unused OAuthConsent props#8352
Draft
wobsoriano wants to merge 3 commits intomainfrom
Draft
chore(ui,shared,types): Remove unused OAuthConsent props#8352wobsoriano wants to merge 3 commits intomainfrom
wobsoriano wants to merge 3 commits intomainfrom
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Remove the accounts portal callback path (hasContextCallbacks) and all deprecated props (scopes, oauthApplicationName, onAllow/onDeny, redirectUrl as a pre-fetched value) now that the accounts portal renders OAuthConsent via URL params without pre-fetched data or JS callbacks. Add redirectUrl as an overridable prop alongside oauthClientId and scope, so callers embedding the component without URL params can supply it directly.
wobsoriano
force-pushed
the
rob/oauth-consent-cleanup
branch
from
a84bf67 to
7a3fd4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change