Skip to content

feat(ui): Reverification flow animation exploration #9607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
austincalvelage wants to merge 5 commits into
base: austin/reverification-flow-block
Choose a base branch
from
Open

feat(ui): Reverification flow animation exploration #9607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c97a2b1
feat(ui): animate Mosaic flow transitions
austincalvelage Aug 28, 2026
9191a46
refactor(ui): compose reverification flow inside card
austincalvelage Aug 28, 2026
30920bd
docs(swingset): refine reverification flow behavior
austincalvelage Aug 28, 2026
19e2d50
fix(ui): remove duplicate destructive dialog close button
austincalvelage Aug 28, 2026
0bb0efb
feat(ui): refine reverification method picker layout
austincalvelage Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 43 additions & 42 deletions packages/swingset/src/stories/flow.component.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,47 +23,48 @@ export function Default(): JSX.Element {
};

return (
<Flow.Root
render={<Card.Root />}
value={step}
direction={direction}
state={{ step }}
>
{state => (
<>
<Flow.Step ids={['details', 'details-pending']}>
<Card.Header>
<Card.Title>Account details</Card.Title>
<Card.Description>Current controller state: {state.step}</Card.Description>
</Card.Header>
<Card.Footer>
<Button
fullWidth
onClick={() => navigate('confirm', 1)}
>
Continue
</Button>
</Card.Footer>
</Flow.Step>
<Flow.Step ids={['confirm']}>
<Card.Header>
<Card.Title>Confirm changes</Card.Title>
<Card.Description>Review the final step before submitting.</Card.Description>
</Card.Header>
<Card.Footer>
<Button
fullWidth
variant='outline'
color='neutral'
onClick={() => navigate('details', -1)}
>
Back
</Button>
<Button fullWidth>Submit</Button>
</Card.Footer>
</Flow.Step>
</>
)}
</Flow.Root>
<Card.Root>
<Flow.Root
value={step}
direction={direction}
state={{ step }}
>
{state => (
<>
<Flow.Step ids={['details', 'details-pending']}>
<Card.Header>
<Card.Title>Account details</Card.Title>
<Card.Description>Current controller state: {state.step}</Card.Description>
</Card.Header>
<Card.Footer>
<Button
fullWidth
onClick={() => navigate('confirm', 1)}
>
Continue
</Button>
</Card.Footer>
</Flow.Step>
<Flow.Step ids={['confirm']}>
<Card.Header>
<Card.Title>Confirm changes</Card.Title>
<Card.Description>Review the final step before submitting.</Card.Description>
</Card.Header>
<Card.Footer>
<Button
fullWidth
variant='outline'
color='neutral'
onClick={() => navigate('details', -1)}
>
Back
</Button>
<Button fullWidth>Submit</Button>
</Card.Footer>
</Flow.Step>
</>
)}
</Flow.Root>
</Card.Root>
);
}
7 changes: 3 additions & 4 deletions packages/swingset/src/stories/reverification.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ function WorkingExample({ onComplete }: { onComplete: () => void }): JSX.Element
setFieldError('That password is incorrect. Try again.');
return;
}
setMethodId('otp');
navigate('otp', 1);
onComplete();
};

const submitOtp = async (code: string) => {
Expand Down Expand Up @@ -152,7 +151,7 @@ function WorkingExample({ onComplete }: { onComplete: () => void }): JSX.Element
onValueChange('');
};

const showMethods = () => navigate('method-picker', 1);
const showMethods = () => navigate('method-picker', -1);
const viewState: ReverificationState = {
status,
password: {
Expand Down Expand Up @@ -223,7 +222,7 @@ function WorkingExample({ onComplete }: { onComplete: () => void }): JSX.Element
pendingMethodId,
onSelect: id => void selectMethod(id),
onHelp: () => navigate('help', 1),
onBack: () => navigate(methodId, -1),
onBack: () => navigate(methodId, 1),
},
help: {
messages: helpMessages,
Expand Down
1 change: 0 additions & 1 deletion packages/ui/src/mosaic/blocks/destructive/destructive.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ export function Destructive({
/>
}
>
<Dialog.CloseButton />
<Card.Header>
<Dialog.Title render={<Heading />}>{title}</Dialog.Title>
<Dialog.Description render={<Text />}>{description}</Dialog.Description>
Expand Down
26 changes: 14 additions & 12 deletions packages/ui/src/mosaic/blocks/reverification/reverification-method-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,23 +88,25 @@ export function ReverificationMethodPicker({
{messages.backButton}
</Button>
) : null}
</Card.Content>
<Card.Footer>
<Text
size='xs'
color='neutral'
style={{
textAlign: 'center',
marginBlockStart: space['1'],
}}
>
{messages.helpText}
{messages.helpText}{' '}
<Button
type='button'
size='sm'
variant='link'
onClick={onHelp}
>
{messages.helpButton}
</Button>
</Text>
<Button
type='button'
size='sm'
variant='link'
onClick={onHelp}
>
{messages.helpButton}
</Button>
</Card.Footer>
</Card.Content>
</>
);
}
2 changes: 1 addition & 1 deletion packages/ui/src/mosaic/blocks/reverification/reverification.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe('Reverification', () => {
const passwordStep = screen.getByLabelText('Password').closest('.cl-flow-step');

expect(card).not.toBeNull();
expect(flow).toBe(card);
expect(card).toContainElement(flow);
expect(flow).toHaveAttribute('data-value', 'password');

const pendingPassword = state('password');
Expand Down
59 changes: 30 additions & 29 deletions packages/ui/src/mosaic/blocks/reverification/reverification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,39 +33,40 @@ export interface ReverificationProps {

export function Reverification({ state, direction }: ReverificationProps): JSX.Element {
return (
<Flow.Root
render={<Card.Root />}
value={state.status}
direction={direction}
state={state}
>
{current => (
<>
<Flow.Step ids={['password']}>
<ReverificationPassword {...current.password} />
</Flow.Step>
<Card.Root>
<Flow.Root
value={state.status}
direction={direction}
state={state}
>
{current => (
<>
<Flow.Step ids={['password']}>
<ReverificationPassword {...current.password} />
</Flow.Step>

<Flow.Step ids={['passkey']}>
<ReverificationPasskey {...current.passkey} />
</Flow.Step>
<Flow.Step ids={['passkey']}>
<ReverificationPasskey {...current.passkey} />
</Flow.Step>

<Flow.Step ids={['otp']}>
<ReverificationOTP {...current.otp} />
</Flow.Step>
<Flow.Step ids={['otp']}>
<ReverificationOTP {...current.otp} />
</Flow.Step>

<Flow.Step ids={['backup-code']}>
<ReverificationBackupCode {...current.backupCode} />
</Flow.Step>
<Flow.Step ids={['backup-code']}>
<ReverificationBackupCode {...current.backupCode} />
</Flow.Step>

<Flow.Step ids={['method-picker']}>
<ReverificationMethodPicker {...current.methodPicker} />
</Flow.Step>
<Flow.Step ids={['method-picker']}>
<ReverificationMethodPicker {...current.methodPicker} />
</Flow.Step>

<Flow.Step ids={['help']}>
<ReverificationHelp {...current.help} />
</Flow.Step>
</>
)}
</Flow.Root>
<Flow.Step ids={['help']}>
<ReverificationHelp {...current.help} />
</Flow.Step>
</>
)}
</Flow.Root>
</Card.Root>
);
}
45 changes: 45 additions & 0 deletions packages/ui/src/mosaic/components/flow/flow.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,54 @@
import * as stylex from '@stylexjs/stylex';

import { durationVars, easingVars } from '../../tokens.stylex';

export const styles = stylex.create({
root: {
overflow: 'hidden',
position: 'relative',
transitionDuration: {
default: durationVars['--cl-duration-slow'],
':where([data-initial])': durationVars['--cl-duration-instant'],
},
transitionProperty: {
default: 'height',
'@media (prefers-reduced-motion: reduce)': 'none',
},
transitionTimingFunction: easingVars['--cl-ease-enter'],
height: 'var(--cl-flow-step-height)',
},
step: {
display: 'flex',
flexDirection: 'column',
insetBlockStart: {
default: null,
':where([data-closed])': 0,
},
insetInlineStart: {
default: null,
':where([data-closed])': 0,
},
position: {
default: 'relative',
':where([data-closed])': 'absolute',
},
transform: {
default: 'translateX(0)',
':where([data-ending-style])': 'translateX(calc(var(--cl-flow-transition-direction, 1) * -100%))',
':where([data-starting-style])': 'translateX(calc(var(--cl-flow-transition-direction, 1) * 100%))',
'@media (prefers-reduced-motion: reduce)': {
default: 'translateX(0)',
':where([data-ending-style])': 'translateX(0)',
':where([data-starting-style])': 'translateX(0)',
},
},
transitionDuration: durationVars['--cl-duration-slow'],
transitionProperty: {
default: 'transform',
'@media (prefers-reduced-motion: reduce)': 'none',
},
transitionTimingFunction: easingVars['--cl-ease-enter'],
willChange: 'transform',
minWidth: 0,
width: '100%',
},
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/mosaic/components/flow/flow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function FlowRoot<State>(
): JSX.Element {
return (
<HeadlessFlow.Root
{...mergeStyleProps(themeProps('flow-root', { value }), stylex.props(reset.base), className, style)}
{...mergeStyleProps(themeProps('flow-root', { value }), stylex.props(reset.base, styles.root), className, style)}
{...rest}
ref={ref}
render={render}
Expand Down
Loading