Conversation
andyfeller
reviewed
May 30, 2024
Contributor
andyfeller
left a comment
andyfeller
left a comment
There was a problem hiding this comment.
@v1v : thank you again for yet another contribution! 🫶
I'd like to get thoughts from @williammartin but these changes are solid as a whole.
Comment on lines
+1
to
+15
| --- | ||
| version: 2 | ||
| updates: | ||
|
|
||
| # GitHub actions | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| day: "sunday" | ||
| time: "22:00" | ||
| groups: | ||
| github-actions: | ||
| patterns: | ||
| - "*" |
Contributor
There was a problem hiding this comment.
Comment on lines
+6
to
+11
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| day: "sunday" | ||
| time: "22:00" |
Contributor
There was a problem hiding this comment.
@williammartin : how consistently should Go and GitHub Actions dependabot PRs be across the cli repositories? how frequently do you expect to address updates?
I ask because cli/cli dependabot settings differ quite a bit and appreciate consistency:
version: 2
updates:
- package-ecosystem: gomod
directory: "/"
schedule:
interval: "daily"
ignore:
- dependency-name: "*"
update-types:
- version-update:semver-minor
- version-update:semver-major
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"Between these changes and cli/cli, I think the groups usage could help cut down on churn of multiple PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enable dependabot for GitHub actions
Why
I've just discovered an action dependency a bit old
That has been annotated with a warning:
This should help with bumping versions in an automated manner :)