fix(auth): improve error reporting when token lookup fails#221
Open
Cris682 wants to merge 2 commits into
Open
Conversation
Return a descriptive error when `gh auth token` command fails or returns empty output, instead of silently falling back to a generic error. This helps users understand the root cause of authentication failures. Update client options resolution to surface the failure reason from TokenForHost when the source indicates a lookup problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #112 by making token lookup errors more actionable.
When token resolution fails, the final error is no longer only the generic authentication token not found ; it now includes concrete failure reasons when available (for example, gh not found in PATH or gh auth token execution failure).
Changes
Why
Previously, specific failures (e.g. missing gh binary) were masked by a generic “token not found” message, making debugging and support harder.
Tests
Added targeted tests:
Backward Compatibility
Related