browser: handle launcher paths that contain spaces#223
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
The launcher was always run through shlex.Split, which turned a path like C:\Program Files\Google\Chrome\Application\chrome.exe into "C:" + "Program" + "Files..." and then complained that "C:" couldn't be found on PATH. Users had to either quote the path themselves or move the executable somewhere without spaces. Try the launcher as a literal path first. If LookPath finds it, use it directly with no extra arguments. Otherwise fall back to the existing shlex-based split so `firefox --private-window` style launchers keep working. Closes cli#174. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #174.
The launcher was always passed through `shlex.Split`, so a path like `C:\Program Files\Google\Chrome\Application\chrome.exe` became `C:` + `Program` + `Files...` and the lookup blew up because `C:` wasn't on PATH. The reported workaround was to move the executable somewhere with no spaces.
Try the launcher as a literal path first. If `LookPath` finds it, use it directly. Otherwise fall back to the existing shlex-based split so launchers with extra args (`firefox --private-window`, `open -a 'Google Chrome'`) keep working.
Added two new tests: