Add on_abort handler support for procedures#4298
Open
onx2 wants to merge 1 commit intoclockworklabs:masterfrom
Open
Add on_abort handler support for procedures#4298onx2 wants to merge 1 commit intoclockworklabs:masterfrom
on_abort handler support for procedures#4298onx2 wants to merge 1 commit intoclockworklabs:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds support for procedure
on_aborthandlers, including macro parsing, bindings propagation, schema validation, and runtime scheduling of the handler when a procedure traps. Also updates V9 validation tests to use the newadd_procedure(..., on_abort)signature.Helps #3789, this allows us to reschedule the procedure when aborted
API and ABI breaking changes
No breaking changes expected. (Adds optional
on_abortmetadata and preserves existing behavior when omitted.)Expected complexity level and risk
Touches multiple layers (macro → bindings → schema → runtime), but the change is additive and limited in scope. Primary risk is mismatched server/client versions or handler scheduling edge cases, mitigated by validation and async scheduling.
Testing
cargo test#[procedure(on_abort = "...")], trigger a trap, and verify handler is scheduled