Trigger view refresh when a V8 procedure commits a transaction#4302
Open
joshua-spacetime wants to merge 2 commits intojoshua/procedures-dont-trigger-viewsfrom
Open
Trigger view refresh when a V8 procedure commits a transaction#4302joshua-spacetime wants to merge 2 commits intojoshua/procedures-dont-trigger-viewsfrom
joshua-spacetime wants to merge 2 commits intojoshua/procedures-dont-trigger-viewsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR fixes the bug where V8 procedures could commit a transaction without refreshing affected materialized views, which caused view-backed subscriptions to miss updates from procedure writes.
API and ABI breaking changes
None
Expected complexity level and risk
3
Almost the exact same change as #4301. The main difference between the V8 change and the WASM change is that for V8 we persist the hook functions (
__call_view__,__call_view_anon__, etc.) and the hook receiver (recv/this) into V8 context embedder slots, and reconstruct them later from syscall scope.Testing