Remove source-config field from spacetime.json#4423
Merged
Conversation
We mistakenly were saving source-config field to the spaacetime.json config file. This commit automatically removes the filed if it's present
drogus
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
cloutiertyler
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
We mistakenly were saving source-config field to the spacetime.json config file. This commit automatically removes the filed if it's present. Note that in order to preserve comments that users might have added we use text based modification, but we validate the resulting JSON before saving
Expected complexity level and risk
2
Testing
I tested locally