Skip to content

CI - cargo ci update-flow runs on Windows #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfops merged 2 commits into from
Apr 23, 2026
Merged

CI - cargo ci update-flow runs on Windows #4874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4941a1
CI - Upgrade job runs on windows
bfops Apr 22, 2026
49f4a8b
Merge branch 'master' into bfops/ci-fix-upgrade
bfops Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,28 +389,10 @@ jobs:
shell: bash
run: sudo apt install -y libssl-dev

- name: Build spacetimedb-update
run: cargo build --features github-token-auth --target ${{ matrix.target }} -p spacetimedb-update
if: runner.os == 'Windows'

- name: Run self-install
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
shell: bash
run: |
ROOT_DIR="$(mktemp -d)"
# NOTE(bfops): We need the `github-token-auth` feature because we otherwise tend to get ratelimited when we try to fetch `/releases/latest`.
# My best guess is that, on the GitHub runners, the "anonymous" ratelimit is shared by *all* users of that runner (I think this because it
# happens very frequently on the `macos-runner`, but we haven't seen it on any others).
cargo run --features github-token-auth --target ${{ matrix.target }} -p spacetimedb-update -- self-install --root-dir="${ROOT_DIR}" --yes
"${ROOT_DIR}"/spacetime --root-dir="${ROOT_DIR}" help
if: runner.os == 'Windows'

- name: Test spacetimedb-update
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: cargo ci update-flow --target=${{ matrix.target }} --github-token-auth
if: runner.os != 'Windows'

unreal_engine_tests:
name: Unreal Engine Tests
Expand Down
7 changes: 6 additions & 1 deletion tools/ci/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,12 @@ fn main() -> Result<()> {
.chain(["--", "self-install", &root_arg, "--yes"].into_iter()),
)
.run()?;
cmd!(format!("{}/spacetime", root_dir_string), &root_arg, "help",).run()?;

let mut spacetime_path = root_dir.path().join("spacetime");
if !std::env::consts::EXE_EXTENSION.is_empty() {
spacetime_path.set_extension(std::env::consts::EXE_EXTENSION);
}
cmd(spacetime_path, [&root_arg, "help"]).run()?;
}

Some(CiCmd::CliDocs { spacetime_path }) => {
Expand Down
Loading