Open
Conversation
rekhoff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add EV code signing for Windows CLI binaries using DigiCert KeyLocker. The workflow now signs
spacetimedb-update.exe,spacetimedb-cli.exe, andspacetimedb-standalone.exeon tag pushes usingsmctl signwith a cloud HSM-backed certificate.These changes reflect the updated DigiCert guidance for code signing through GitHub found here: https://github.com/marketplace/actions/digicert-binary-signing
API and ABI breaking changes
No API or ABI changes. This change only affects the CI/CD packaging workflow.
Expected complexity level and risk
1 - This PR only adds code signing to existing CI packaging. Risk is limited to the Windows packaging step failing on tags; Linux and macOS builds are unaffected.
Testing
test-signing-v0.0.1