Stop tracking multiple plan types in the subscription cache#5263
Open
joshua-spacetime wants to merge 1 commit into
Open
Stop tracking multiple plan types in the subscription cache#5263joshua-spacetime wants to merge 1 commit into
joshua-spacetime wants to merge 1 commit into
Conversation
joshua-spacetime
force-pushed
the
joshua/refactor/subscription-plan-cache
branch
from
6c73204 to
87b0604
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Required before we add formal parameters to query plans which in turn is required to support parameterized views.
Before this change, we cached two types of query representations for a subscription - a physical plan and what we call a pipelined executor.
This was mainly an artifact of built up technical debt, so this change removes the physical plan and only caches the actual executor for the subscription, in preparation for adding bind variables that are substituted by the executor at runtime.
API and ABI breaking changes
N/A
Expected complexity level and risk
...
Testing
Existing coverage