Skip to content

CI - Disallow npm-installed pnpm - #5895

Merged
bfops merged 7 commits into
masterfrom
bot/widen-pnpm-workflow-lint
Sep 10, 2026
Merged

CI - Disallow npm-installed pnpm#5895
bfops merged 7 commits into
masterfrom
bot/widen-pnpm-workflow-lint

Conversation

@clockwork-labs-bot

@clockwork-labs-bot clockwork-labs-bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description of Changes

Follow-up to #5894.

We have an existing check that disallows "raw" pnpm/action-setup in CI, so that everything must go through our custom pnpm installation action that also sets minimum package age. However, we were not checking for npm install pnpm. This PR fixes that.

Also updates the existing release workflow pnpm setup step to use ./.github/actions/setup-pnpm, so the new check passes.

API and ABI breaking changes

N/A

Rollback safety impact

n/a

Expected complexity level and risk

1

Testing

CI passes

Comment thread tools/ci/commands/lint/src/main.rs Outdated
@bfops bfops changed the title Disallow npm-installed pnpm in workflows CI - Disallow npm-installed pnpm Sep 9, 2026

@jdetter jdetter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bfops
bfops enabled auto-merge September 9, 2026 14:35
@bfops
bfops added this pull request to the merge queue Sep 10, 2026
@bfops
bfops removed this pull request from the merge queue due to a manual request Sep 10, 2026
@bfops
bfops added this pull request to the merge queue Sep 10, 2026
Merged via the queue into master with commit a24c484 Sep 10, 2026
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants