[T3 Connect] Negotiate HTTP/2 for procedure HTTPS requests - #6012
Draft
bradleyshep wants to merge 1 commit into
Draft
bradleyshep wants to merge 1 commit into
bradleyshep wants to merge 1 commit into
Conversation
|
I need this fix for iOS push notifications. |
bradleyshep
force-pushed
the
bradley/procedure-http2
branch
from
September 30, 2026 15:57
dab05ee to
9624673
Compare
5 tasks done
bradleyshep
force-pushed
the
bradley/procedure-http2
branch
from
September 30, 2026 17:45
9624673 to
03e80c8
Compare
Enable reqwest's `native-tls-alpn` feature so the native-tls connector offers ALPN `h2`. Without it every outbound `ctx.http.fetch` over HTTPS was pinned to HTTP/1.1, and HTTP/2-only APIs such as Apple's APNs (iOS push notifications) could not be reached from modules.
bradleyshep
force-pushed
the
bradley/procedure-http2
branch
from
October 1, 2026 17:26
03e80c8 to
adce315
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This enables reqwest's
native-tls-alpnfeature, so the native-tls connector offers ALPNh2. Without it, every outboundctx.http.fetchover HTTPS was pinned to HTTP/1.1, and HTTP/2-only APIs could not be reached from modules. One example is Apple's APNs, which modules need for iOS push notifications.Split out of #6005 / #6006.
API and ABI breaking changes
None.
Rollback safety impact
n/a
Expected complexity level and risk
Worth a reviewer's eye: the flag is on the workspace
reqwest, and release builds compile the CLI, updater and standalone server together, so the CLI and updater also start offering HTTP/2 over TLS. Scoping it tospacetimedb-corewouldn't change that, because Cargo unifies features across one build. Maincloud and GitHub select HTTP/2 when offered; the S3 bucket for client binaries stays on HTTP/1.1.spacetime server ping maincloudworks with a build of this branch; publish, logs andspacetime version upgradeover HTTP/2 weren't tested.Testing
http_request_offers_h2_over_tls(behindallow_loopback_http_for_tests, like the decompression tests beside it): a procedure HTTPS request made throughInstanceEnv::http_requestoffersh2via ALPN in its TLS ClientHello. Without this change it offers no ALPN protocols, so an HTTP/2-only server such as APNs has nothing to select.native-tls-alpnremovedcargo test --alldoesn't enableallow_loopback_http_for_tests, so this test doesn't run in CI on its own; [T3 Connect] Reuse one HTTP client per replica for procedure requests #6023 adds a focused CI step that runs the loopback HTTP tests, including this one once both land.