Replace the Leiningen build with tools.build#52
Merged
Conversation
The Leiningen build only existed to translate deps.edn into a project.clj (via a ~140-line lein-git-down shim) so that lein could build and deploy the jar. tools.build works from deps.edn directly, so the shim, project.clj and the :pack alias are all gone. build.clj exposes clean/jar/install/deploy; the version still comes from PROJECT_VERSION, and deploy goes to Clojars via deps-deploy. The Makefile and the CI deploy job call 'clojure -T:build ...' instead of lein. The generated pom matches the current published one for the transitively relevant deps (ClojureScript, Clojure, compliment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Reopens #51, which got stuck after the base branch it was stacked on merged.)
The Leiningen build only existed so
leincould build and deploy the jar, and it needed a ~140-linelein-git-downshim inproject.cljto translatedeps.edninto a Leiningen project (mostly to make the git deps work under lein).tools.buildreadsdeps.edndirectly, so all of that goes away.build.cljexposesclean/jar/install/deploy; the version still comes fromPROJECT_VERSION, and deploy pushes to Clojars viadeps-deploy. The Makefile and the CI deploy job now callclojure -T:build ....I verified
clojure -T:build jarandmake installlocally: the generated pom carries the same transitively-relevant deps as the current published one (ClojureScript, Clojure, compliment), and actually drops two spurioustest-scope entries (cider-nrepl, piggieback) that the lein translation used to emit. The one thing I couldn't exercise is the real Clojars upload.