Actually run the static completion test suite#55
Merged
Conversation
The tests in what was src/test/suitable/compliment/sources/t_cljs.clj never ran in CI: the cognitect test-runner only picks up namespaces matching #".*-test$", and this one was named ...t-cljs (the old t_ convention). Renaming it to cljs_test.clj brings its 15 tests / 68 assertions into every run. Two of those tests had stale expectations (they'd never been executed): completing "foo" in the test ns also matches the local `foo` def, not just the referred `foo-in-dep`. Tightened the prefix to "foo-in" so each test stays focused on the referred var it's exercising.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static ClojureScript completion tests (formerly
t_cljs.clj) never ran in CI - the test-runner only matches*-testnamespaces, and this one was namedt-cljsfrom the oldt_convention. Renaming it tocljs_test.cljpulls its 15 tests / 68 assertions into every run.Running them for the first time surfaced two stale expectations: completing
fooin the test ns also matches the localfoodef, not just the referredfoo-in-dep. I tightened those prefixes tofoo-inso each test stays focused.No production code changes - this is purely getting the existing suite to actually execute.