fix: spawn-reviewer.sh のプロンプトから gh pr review のハードコードを削除#515
Merged
clonable-eden merged 4 commits intomainfrom Mar 23, 2026
Merged
fix: spawn-reviewer.sh のプロンプトから gh pr review のハードコードを削除#515clonable-eden merged 4 commits intomainfrom
clonable-eden merged 4 commits intomainfrom
Conversation
…of hardcoding gh pr review (RED) spawn-reviewer.sh prompt currently hardcodes "gh pr review", which overrides reviewer.md's Self-Review Pre-Detection procedure (gh api). Test now asserts: - prompt does NOT contain "gh pr review" - prompt delegates to "agent definition" closes #514 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…REEN) Replace "Submit your review via gh pr review" with "Follow the review submission procedure in your agent definition" so that reviewer.md's Self-Review Pre-Detection (gh api) is not overridden by the spawn prompt. closes #514 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Renumber Test 18 → 17, old Test 17 → 18 so tests appear in sequential order. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
clonable-eden
commented
Mar 23, 2026
Owner
Author
clonable-eden
left a comment
clonable-eden
left a comment
There was a problem hiding this comment.
Review: APPROVE ✅
正確性
Issue #514 の根本原因（spawn プロンプトの gh pr review ハードコードが reviewer.md の gh api 手順を上書き）に対して、正確に修正されている。プロンプトを Follow the review submission procedure in your agent definition に変更することで、reviewer.md の Self-Review Pre-Detection 手順への委譲が実現される。
規約
- conventional commits (
fix:) 適切 - TDD サイクル (RED → GREEN → REFACTOR) のコミット接尾辞あり
set -euo pipefail維持- bash 3.2 互換パターン (
$((var + 1))) 使用
テスト
- Test 16:
gh pr reviewがプロンプトに含まれないことを検証（反転テスト）— 回帰防止として適切 - Test 17:
agent definitionへの委譲を検証 — ポジティブテストとして適切 - REFACTOR コミットでテスト番号の論理順序を修正
スコープ
変更は spawn-reviewer.sh の1行と対応テストのみ。余計な変更なし。
CI
4 checks すべて pass。
Note: Self-review のため COMMENT として投稿。Verdict は APPROVE。
clonable-eden
deleted the
issue/514-spawn-reviewer-sh-reviewer-md-gh-api
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #514
Summary
spawn-reviewer.shのプロンプトからSubmit your review via gh pr reviewを削除し、Follow the review submission procedure in your agent definitionに変更reviewer.mdの Self-Review Pre-Detection（gh api使用）手順が正しく実行されるようになるTest Plan
gh pr reviewがハードコードされていないことを確認agent definitionに委譲していることを確認