Skip to content

CLAUDE.md: 非実行ファイルへの不要テスト防止ガードレール強化#518

Merged
clonable-eden merged 1 commit intomainfrom
issue/517-claude-md
Mar 23, 2026
Merged

CLAUDE.md: 非実行ファイルへの不要テスト防止ガードレール強化#518
clonable-eden merged 1 commit intomainfrom
issue/517-claude-md

Conversation

@clonable-eden
Copy link
Copy Markdown
Owner

closes #517

Summary

  • ## Review > ### Testing Criteria に「No tests for non-executable files」基準を追加(Reviewer が content-based テストを検出・reject できるようにする)
  • ## Testing > ### What to Test に TDD との優先順位を明示(Worker が非実行ファイル変更で RED テストを書かないようにする)

Test Plan

  • CLAUDE.md の変更内容が正確であることを確認
  • 既存テストが影響を受けないことを CI で確認

🤖 Generated with Claude Code

…ble files

Add review criterion for Reviewers to detect and reject content-based tests
for non-executable files. Clarify TDD priority for Workers: the no-test rule
for non-executable files takes precedence over TDD's RED step.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Owner Author

@clonable-eden clonable-eden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: APPROVE ✅

All changes correctly implement what issue #517 requested. CI passes.

Correctness

  • Testing Criteria (line 63): "No tests for non-executable files" criterion added to ## Review > ### Testing Criteria — Reviewers will now detect and reject content-based tests on non-executable files.
  • What to Test (lines 225-226): TDD precedence clarification added — Workers will now know that the no-test rule overrides TDD for non-executable file changes.

Conventions

  • Documentation-only CLAUDE.md change — no tests required (per the very rule being added).
  • PR body includes closes #517. Branch naming follows conventions.

Scope

  • Exactly 3 lines added across 2 sections. No unrelated modifications.

CI

  • All checks pass (cekernel tests, auto-approve, test, changes).

LGTM — ready to merge.

@clonable-eden clonable-eden merged commit d35105b into main Mar 23, 2026
4 checks passed
@clonable-eden clonable-eden deleted the issue/517-claude-md branch March 23, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLAUDE.md: 非実行ファイルへの不要テスト防止ガードレール強化

1 participant