fix(code): tighten guided-manual-qa service readiness - #211
Merged
Merged
Conversation
mikeangstadt
approved these changes
Sep 30, 2026
mikeangstadt
left a comment
Collaborator
There was a problem hiding this comment.
Good tightening. The "started means started" distinction is the one that actually bites in practice. Version bump and CHANGELOG line up, 46 tests still green. One note on test pinning below, not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens the environment readiness rules in the
guided-manual-qaskill so a QA session doesn't start against a service that isn't actually up, or against ports shared with another worker.startedno longer counts as ready. The actual listener and the route-owned ready selector must be proven before a checkpoint is presented.Bumps
codeto v1.16.2 and adds the CHANGELOG entry.Testing
npm testintools/guided-manual-qa: 46 tests pass, including the skill contract tests that pin SKILL.md text.