Send heartbeats to upstream connections - #250
Merged
Merged
Conversation
spuun
force-pushed
the
send-upstream-heartbeats-on-interval
branch
from
August 28, 2026 11:13
a5192a6 to
9597bbe
Compare
kickster97
reviewed
Aug 28, 2026
kickster97
approved these changes
Aug 28, 2026
| @channel_max : UInt16 | ||
| @lock = Mutex.new | ||
| @remote_address : String | ||
| @channel_max : UInt16 |
Member
There was a problem hiding this comment.
not introduced in this pr, but we declare @channel_max twice
| tune_ok, @credentials = negotiate(@socket) | ||
| # The largest frame we offer the client in Connection#Tune, the client can | ||
| # only negotiate it down, so it's also the limit we enforce when reading | ||
| FRAME_MAX = 131_072_u32 |
Member
There was a problem hiding this comment.
declared in 3 places, could maybe be global?
|
Good if we split the docker etc etc changes with the actual changes? |
Member
Author
Yes, we'll merge #252 first. |
carlhoerberg
approved these changes
Aug 29, 2026
Heartbeats were only sent as a reply to the server's own heartbeats, but RabbitMQ doesn't send any while it's busy delivering to a consumer. An upstream connection that was quiet in the proxy->server direction was then closed by the server with "missed heartbeats from client".
spuun
force-pushed
the
send-upstream-heartbeats-on-interval
branch
from
August 29, 2026 12:01
c06cef4 to
2ac53ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMQProxy should send heartbeats to the upstream on interval if no other frame has been sent.
Fixes #210
NOTE:
This is stacked on #252