Use TranscodingStream for converting to UTF-8#342
Draft
erwinkramer wants to merge 1 commit intocloudevents:mainfrom
Draft
Use TranscodingStream for converting to UTF-8#342erwinkramer wants to merge 1 commit intocloudevents:mainfrom
TranscodingStream for converting to UTF-8#342erwinkramer wants to merge 1 commit intocloudevents:mainfrom
Conversation
Signed-off-by: Erwin <erwinkramer@hotmail.com>
Contributor
|
This feels like it's reasonable - it's entirely an implementation detail, so a simple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leverages
CreateTranscodingStreamto change the encoding to UTF-8 when required. This is only possible on later framework versions, so should be decided if we really want this.