🐛 Refactor toReader method in CloudEventHttpUtils to provide a temporary workaround to issue #704#743
Open
ranma2913 wants to merge 1 commit into
Open
🐛 Refactor toReader method in CloudEventHttpUtils to provide a temporary workaround to issue #704#743ranma2913 wants to merge 1 commit into
toReader method in CloudEventHttpUtils to provide a temporary workaround to issue #704#743ranma2913 wants to merge 1 commit into
Conversation
…mporary workaround to [cloudevents#704](cloudevents#704) Spring Framework 7 changed org.springframework.http.HttpHeaders so it no longer implements the Map / MultiValueMap contract. Current versions of io.cloudevents:cloudevents-spring pass HttpHeaders directly to: HttpMessageFactory.createReaderFromMultimap(headers, body.get()); The CloudEvents HTTP reader expects a Map<String, List<String>>, so applications running Spring Framework 7 fail while deserializing inbound CloudEvents with: java.lang.IncompatibleClassChangeError: Class org.springframework.http.ReadOnlyHttpHeaders does not implement the requested interface java.util.Map In WebFlux, Reactor treats this linkage error as fatal. The HTTP exchange can remain incomplete, causing callers such as WebTestClient to report a timeout instead of the underlying exception. Signed-off-by: Joel Sticha (ranma2913) <4295880+ranma2913@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Refactor
toReadermethod inCloudEventHttpUtilsto provide a temporary workaround to #704Spring Framework 7 changed org.springframework.http.HttpHeaders so it no longer implements the Map / MultiValueMap contract.
Current versions of io.cloudevents:cloudevents-spring pass HttpHeaders directly to:
HttpMessageFactory.createReaderFromMultimap(headers, body.get()); The CloudEvents HTTP reader expects a Map<String, List>, so applications running Spring Framework 7 fail while deserializing inbound CloudEvents with:
java.lang.IncompatibleClassChangeError:
Class org.springframework.http.ReadOnlyHttpHeaders does not implement the requested interface java.util.Map
In WebFlux, Reactor treats this linkage error as fatal. The HTTP exchange can remain incomplete, causing callers such as WebTestClient to report a timeout instead of the underlying exception.