Repository navigation
fix(json): serialize non-dict data as JSON in binary mode - #312
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #311
Type of change:
Description:
JSONFormat.write_dataonly JSON-encodesdictdata. Other JSON values, such as lists and booleans, fall through tostr(data). Binary content mode then sends Python reprs like['a', 'b']orTrueas the body, even withdatacontenttype: application/json. This affects the HTTP, Kafka, AMQP and RabbitMQ bindings.This change applies the existing JSON handling to every value that isn't
None,strorbytes. It keeps the current behavior otherwise:str(data)onTypeError, as added in fix: improve json handling on wrong or missing contenttype #297.Tests:
test_write_data_non_dict_json_valuecovers a list, a boolean and a float with no content type,application/jsonandapplication/octet-stream. Without the fix, the list and boolean cases fail.Pre-submission checklist:
git commit --signoff.README.md,CHANGELOG.md, etc.) as necessary.pre-commitandtoxand all checks pass.