fix(voice): gapless audio chunk playback#1747
Open
cjol wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 8e4717e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes audible clicks at audio chunk boundaries during agent speech in
VoiceClient. Closes #1736.Why
VoiceClientplayed each response chunk by starting it atcurrentTimeand waiting for itsendedevent before scheduling the next. The round-trip latency (event-loop delay plus the next chunk's setup) left a few milliseconds of silence at every seam, audible as a periodic click.endedcallbacks run on the main thread, not the audio clock, so there will always be some gap.Code Changes
packages/voice/src/voice-client.ts#activeSourcewith a#scheduledSourcesset and a#playbackCursor. Each incoming chunk is scheduled atMath.max(currentTime, cursor), and the cursor is advanced by the chunk duration.#stopPlaybackstops every scheduled source, not just the current one, so an interrupt or end-call cleanly cancels the whole pipeline.packages/voice/src/tests/voice-client.test.tscurrentTime, interrupt stops all scheduled chunks, barge-in works through the scheduled tail, and cursor reset on end-call.