Fixed invalid CORS wildcard example#28138
Merged
elithrar merged 1 commit intoproductionfrom Feb 9, 2026
Merged
Conversation
Co-authored-by: elithrar <elithrar@users.noreply.github.com>
Contributor
|
This PR requires additional review attention because it affects the following areas: PartialsThis PR updates partial files, which are pieces of content used across multiple files in our Render component.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
elithrar
approved these changes
Feb 6, 2026
Contributor
|
Preview URL: https://c3877da6.preview.developers.cloudflare.com |
elithrar
approved these changes
Feb 6, 2026
elithrar
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No type checker available in CI, but the changes are syntactically straightforward JSX. The edit is correct.
Summary of changes:
The issue correctly identifies that the Workers CORS example used an invalid
Access-Control-Allow-Originvalue with a wildcard pattern (https://*-:worker.:subdomain.workers.dev/). Per the WHATWG Fetch spec, only*,null, or an exact origin are valid values.What changed in
src/content/partials/workers/custom_headers.mdx:Access-Control-Allow-Origin: https://*-:worker.:subdomain.workers.dev/_headersAccess-Control-Allow-Origin: https://staging.:project.pages.dev/) which is valid since it specifies an exact originCloses #22002
github run