Skip to content

[Workers] Fix typos in React Router guide#28141

Merged
MattieTK merged 1 commit intoproductionfrom
edmundhung/react-router-guide-update
Feb 21, 2026
Merged

[Workers] Fix typos in React Router guide#28141
MattieTK merged 1 commit intoproductionfrom
edmundhung/react-router-guide-update

Conversation

@edmundhung
Copy link
Member

Summary

Just notice a few typos and a legacy flag mentioned in the React Router guide.

Screenshots (optional)

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The change adheres to the documentation style guide.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

In this file:
- `ssr` is set to `true`, meaning that your application will use server-side rendering.
- `future.unstable_viteEnvironmentApi` is set to `true` to enable compatibility with the [Cloudflare Vite plugin](/workers/vite-plugin/).
- `future.v8_viteEnvironmentApi` is set to `true` to enable compatibility with the [Cloudflare Vite plugin](/workers/vite-plugin/).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is stabilized in v7.10.0

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/docs/workers/ @cloudflare/workers-docs, @GregBrimble, @irvinebroque, @mikenomitch, @korinne, @WalshyDev, @cloudflare/deploy-config, @cloudflare/pcx-technical-writing, @cloudflare/wrangler, @mattietk

@elithrar
Copy link
Collaborator

elithrar commented Feb 6, 2026

/bonk review this PR

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Feb 6, 2026

I can see the changes have already been applied to the base branch file (the diff shows the before/after). Let me review each change carefully.

PR Review: [Workers] Fix typos in React Router guide

This is a clean, well-scoped PR with 5 corrections across 1 file. All changes are legitimate fixes. Here's the breakdown:

Change 1: future.unstable_viteEnvironmentApi -> future.v8_viteEnvironmentApi (line 75)

Correct. The author notes this was stabilized in React Router v7.10.0. The unstable_ prefix was dropped and renamed to v8_viteEnvironmentApi. The docs should reflect the stable API name.

Change 2: WorkflowEvent<Params> -> WorkflowEvent<{ hello: string }> (line 147)

Correct. The Params type was never defined anywhere in the code example. Using { hello: string } is consistent with the create({ params: { "hello": "world" } }) call later in the example, making the code snippet self-contained and actually compilable.

Change 3: Route.LoaderArgs -> Route.ActionArgs (line 197)

Correct. The function is named action, not loader. An action function should use Route.ActionArgs, not Route.LoaderArgs. This was a clear copy-paste typo.

Change 4: Missing closing brace }) -> } ) (line 199)

Correct. The original had { "hello": "world" }) which is missing the closing } for the params object literal. The fix adds the missing brace: { "hello": "world" } ).

Change 5: instance.status() -> await instance.status() (line 200)

Correct. instance.status() returns a Promise, so it needs to be awaited to get the actual status value. Without await, the returned object would contain a pending Promise rather than the resolved status.

Verdict

All 5 fixes are valid and improve the correctness of the documentation. No issues found. This PR is ready to merge.

github run

@github-actions
Copy link
Contributor

Hey there, we've marked this pull request as stale because there's no recent activity on it. This label is helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant).

@github-actions github-actions bot added the stale label Feb 21, 2026
@MattieTK MattieTK merged commit 05997dc into production Feb 21, 2026
13 checks passed
@MattieTK MattieTK deleted the edmundhung/react-router-guide-update branch February 21, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/s stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants